Wireshark mailing list archives
Re: -commits emails
From: Evan Huus <eapache () gmail com>
Date: Sun, 9 Feb 2014 21:21:24 -0500
On Wed, Feb 5, 2014 at 9:33 AM, Jeff Morriss <jeff.morriss.ws () gmail com> wrote:
I saw some emails about the -commits emails still being a work in progress but that was a while ago. Is that still the case? I just thought I'd mention that I'm not a fan of the current mails where we only get the one line summary of the change: I'd (much) prefer to have the full text of the commit message.
And as of this morning (or perhaps slightly earlier) I've stopped receiving them at all...? You can ask Gerrit (in your user preferences) to send you notification whenever a patchset is submitted; I'm not sure what those emails look like but they might be more useful.
For example I'd rather see this:Fix Bug 9725 'Lua: ProtoField.new() is buggy' Using ProtoField.new() is dicey. Many of the optional arguments don't properly check the lua stack - they call lua_isnil() for their index number, instead of lua_gettop() to see the stack size. lua_isnil() may return false in such cases.Than:from c391d74 Fix wslua docs script to handle module names with digits, like Int64/UInt64 adds 2466a7c Fix Bug 9725 'Lua: ProtoField.new() is buggy'I can learn a lot more (and better follow what others are discovering/working on) with the details in the former example. ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- -commits emails Jeff Morriss (Feb 05)
- Re: -commits emails Guy Harris (Feb 05)
- Re: -commits emails Evan Huus (Feb 09)
- Re: -commits emails Alexis La Goutte (Feb 10)
- Re: -commits emails Gerald Combs (Feb 10)
- Re: -commits emails Jeff Morriss (Feb 10)
- Re: -commits emails Alexis La Goutte (Feb 10)
- <Possible follow-ups>
- Re: -commits emails mmann78 (Feb 12)
- Re: -commits emails Evan Huus (Feb 12)
- Re: -commits emails mmann78 (Feb 12)