Wireshark mailing list archives

Re: Git+gerrit status update - 2014-01-14


From: Evan Huus <eapache () gmail com>
Date: Tue, 25 Feb 2014 17:51:49 -0500

On Tue, Feb 25, 2014 at 5:42 PM, Joerg Mayer <jmayer () loplof de> wrote:
On Tue, Feb 25, 2014 at 05:01:55PM -0500, Evan Huus wrote:
It sets up so that "git review" does the correct push, as well as
setting the gerrit topic to the current branch name (if different from
"master") and a few other conveniences. So there's no particular
reason to set up git push. This lets admins differentiate between push
(which force-pushes to master for admin purposes) and review (which
goes to gerrit).

Ah, now I understand! So now that I have managed to get my first three
commits into review, how do I proceed on the command line?
The reason I need to ask is that intro-quick only explains the workflow
via web browser - which is something that I'm not intending to use.
If I understand things correctly I should be able to do the same thing
using "git review", or am I wrong here somehow?

Git review is just a wrapper to provide shortcuts for certain actions
[1]. The core actions you will want to perform are done via SSH [2]. I
suspect the two you'll want to use regularly are "query" and "review"
though I haven't tried the SSH interface. As far as I know git review
doesn't provide shortcuts specifically for those.

[1] https://github.com/openstack-infra/git-review#usage
[2] https://code.wireshark.org/review/Documentation/cmd-index.html#_server
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe


Current thread: