Re: Removal of reedsolomon code

[Evan Huus <eapache () gmail com>]

Good catch, thanks. Fixed in g7878878

On Fri, Feb 14, 2014 at 9:21 AM, Alexis La Goutte
<alexis.lagoutte () gmail com> wrote:
> 1bbe5cf by Evan Huus (eapache@...):
>
>     Add correct license headers for reedsolomon code.
>
>     I got in contact with the original author (thanks to Didier for digging
> up his
>     current email address) and verified that we could license this under the
> GPLv2+.
>
>     Licensecheck finally passes!
>
>     Change-Id: I6660ef9a961626bbc4dad53e8bf767b5b9e0b3fa
>     Reviewed-on: https://code.wireshark.org/review/183
>     Reviewed-by: Evan Huus <eapache@...>
>
>
> Nice work ! ;-)
> But there is no a new issue with epan/wslua/wslua_strict.c...
>
> Using base directory: /home/wireshark/builders/trunk/ubuntu1204x64/build
> Checking: /home/wireshark/builders/trunk/ubuntu1204x64/build
>
> 'epan/wslua/wslua_struct.c' has non-whitelisted license 'UNKNOWN'
>
> FAILED
>
>
>
>
> On Tue, Feb 11, 2014 at 11:08 PM, Evan Huus <eapache () gmail com> wrote:
> > Ah, the email in the source file was dead so I gave up, but that looks
> > like the same person, I will try contacting him.
> >
> > Thanks,
> > Evan
> >
> > On Tue, Feb 11, 2014 at 3:53 PM, Didier <dgautheron () magic fr> wrote:
> > > Hi,
> > >
> > > On Tue, 11 Feb 2014 13:07:15 -0500, Evan Huus wrote
> > > > As per my previous emails, the only questionably-licensed code we
> > > > have left is the reed-solomon implementation. It is used only in
> > > > packet-dcp-etsi.c.
> > > >
> > > > I have failed to find any other suitably-licensed reed-solomon
> > > > implementations, and don't have time to write one myself. As such I
> > > > think our best course of option is to remove the current code and
> > > > disable that feature in the DCP-ETSI dissector.
> > > >
> > > > I will submit a change to that effect shortly unless there are
> > > > objections.
> > > Did you try to contact Phil Karn? This stuff seems to be in linux kernel
> > > and I
> > > doubt it's GPL1, moreover he has LGPL code at http://www.ka9q.net/
> > >
> > > Didier
> > >
> > >
> > >
> > >
> > >
> > > ___________________________________________________________________________
> > > Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> > > Archives:    http://www.wireshark.org/lists/wireshark-dev
> > > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
> > >
> > > mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
> >
> > ___________________________________________________________________________
> > Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> > Archives:    http://www.wireshark.org/lists/wireshark-dev
> > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
> >
> > mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
>
>
>
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> Archives:    http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe