Wireshark mailing list archives
Re: Removal of reedsolomon code
From: Alexis La Goutte <alexis.lagoutte () gmail com>
Date: Fri, 14 Feb 2014 15:21:18 +0100
1bbe5cf by Evan Huus (eapache@... <http://gmane.org/get-address.php?address=eapache%2dRe5JQEeQqe8AvxtiuMwx3w%40public.gmane.org>): Add correct license headers for reedsolomon code. I got in contact with the original author (thanks to Didier for digging up his current email address) and verified that we could license this under the GPLv2+. Licensecheck finally passes! Change-Id: I6660ef9a961626bbc4dad53e8bf767b5b9e0b3fa Reviewed-on: https://code.wireshark.org/review/183 Reviewed-by: Evan Huus <eapache@... <http://gmane.org/get-address.php?address=eapache%2dRe5JQEeQqe8AvxtiuMwx3w%40public.gmane.org>> Nice work ! ;-) But there is no a new issue with epan/wslua/wslua_strict.c... Using base directory: /home/wireshark/builders/trunk/ubuntu1204x64/build Checking: /home/wireshark/builders/trunk/ubuntu1204x64/build 'epan/wslua/wslua_struct.c' has non-whitelisted license 'UNKNOWN' FAILED On Tue, Feb 11, 2014 at 11:08 PM, Evan Huus <eapache () gmail com> wrote:
Ah, the email in the source file was dead so I gave up, but that looks like the same person, I will try contacting him. Thanks, Evan On Tue, Feb 11, 2014 at 3:53 PM, Didier <dgautheron () magic fr> wrote:Hi, On Tue, 11 Feb 2014 13:07:15 -0500, Evan Huus wroteAs per my previous emails, the only questionably-licensed code we have left is the reed-solomon implementation. It is used only in packet-dcp-etsi.c. I have failed to find any other suitably-licensed reed-solomon implementations, and don't have time to write one myself. As such I think our best course of option is to remove the current code and disable that feature in the DCP-ETSI dissector. I will submit a change to that effect shortly unless there areobjections.Did you try to contact Phil Karn? This stuff seems to be in linux kerneland Idoubt it's GPL1, moreover he has LGPL code at http://www.ka9q.net/ Didier___________________________________________________________________________Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org ?subject=unsubscribe
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Removal of reedsolomon code Evan Huus (Feb 11)
- Re: Removal of reedsolomon code Didier (Feb 11)
- Re: Removal of reedsolomon code Evan Huus (Feb 11)
- Re: Removal of reedsolomon code Alexis La Goutte (Feb 14)
- Re: Removal of reedsolomon code Evan Huus (Feb 14)
- Re: Removal of reedsolomon code Evan Huus (Feb 11)
- Re: Removal of reedsolomon code Didier (Feb 11)