Wireshark mailing list archives
Re: Gerrit patches with trailing whitespace
From: Peter Kjellerstedt <peter.kjellerstedt () axis com>
Date: Tue, 26 Aug 2014 09:38:07 +0200
-----Original Message----- From: wireshark-dev-bounces () wireshark org [mailto:wireshark-dev- bounces () wireshark org] On Behalf Of Evan Huus Sent: den 25 augusti 2014 19:32 To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] Gerrit patches with trailing whitespace On Mon, Aug 25, 2014 at 1:21 PM, Graham Bloice <graham.bloice () trihedral com> wrote:On 25 August 2014 18:17, Graham Bloice <graham.bloice () trihedral com>wrote:On 25 August 2014 18:11, Juan Jose Martin Carrascosa <juanjo () rti com> wrote:I think that you are talking about my just committed changes. Ijust didit and I just checked in the website that it has the whitespaces... As Evan said, I don't have it installed by default and I wasn'treallyaware of the process (even reading the doc a couple of times). I amreallysorry. I will take a look at how to "stop" my changes from being reviewedandfix it. Thanks! JuanjoIt's just a trivial thing to have to go around the submission looponceagain. Annoying for both the submitter and the reviewer, as we allknowtrailing white space is a heinous crime :-) Did git-review install the hook for me, I can't think where else itcamefrom?Should we add some info then to the Dev Guide as to where to get thehook, It's already in http://wiki.wireshark.org/Development/SubmittingPatches#Setup We keep running into this problem - should the wiki page and the dev guide be consolidated?and also run a server-side hook to reject the push?+1 if we can figure out how to return a nice error message explanation and not just "Your change was rejected by the remote server."
Any output from the hook to stdout (and stderr) will be sent back to the client side and displayed to the user so that should be trivial.
-- Graham Bloice
//Peter ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Gerrit patches with trailing whitespace Graham Bloice (Aug 25)
- Re: Gerrit patches with trailing whitespace Evan Huus (Aug 25)
- Re: Gerrit patches with trailing whitespace Juan Jose Martin Carrascosa (Aug 25)
- Re: Gerrit patches with trailing whitespace Graham Bloice (Aug 25)
- Re: Gerrit patches with trailing whitespace Graham Bloice (Aug 25)
- Re: Gerrit patches with trailing whitespace Evan Huus (Aug 25)
- Re: Gerrit patches with trailing whitespace Alexis La Goutte (Aug 25)
- Re: Gerrit patches with trailing whitespace Bill Meier (Aug 25)
- Re: Gerrit patches with trailing whitespace Juan Jose Martin Carrascosa (Aug 25)
- Re: Gerrit patches with trailing whitespace Evan Huus (Aug 25)
- Re: Gerrit patches with trailing whitespace Graham Bloice (Aug 25)
- <Possible follow-ups>
- Re: Gerrit patches with trailing whitespace Peter Kjellerstedt (Aug 26)