Wireshark mailing list archives
Re: Gerrit patches with trailing whitespace
From: Juan Jose Martin Carrascosa <juanjo () rti com>
Date: Mon, 25 Aug 2014 19:11:58 +0200
I think that you are talking about my just committed changes. I just did it and I just checked in the website that it has the whitespaces... As Evan said, I don't have it installed by default and I wasn't really aware of the process (even reading the doc a couple of times). I am really sorry. I will take a look at how to "stop" my changes from being reviewed and fix it. Thanks! Juanjo On Mon, Aug 25, 2014 at 7:08 PM, Evan Huus <eapache () gmail com> wrote:
Probably they are simply not installing the hook - none of our tooling sets it up by default that I'm aware of. On Mon, Aug 25, 2014 at 1:06 PM, Graham Bloice <graham.bloice () trihedral com> wrote:When reviewing some submissions on Gerrit, I've noted a few with trailing whitespace. The git pre-commit hook always warns me of this, so how are folks managing to do this? Are they using clients that ignore the hook? -- Graham Bloice___________________________________________________________________________Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org ?subject=unsubscribe
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Gerrit patches with trailing whitespace Graham Bloice (Aug 25)
- Re: Gerrit patches with trailing whitespace Evan Huus (Aug 25)
- Re: Gerrit patches with trailing whitespace Juan Jose Martin Carrascosa (Aug 25)
- Re: Gerrit patches with trailing whitespace Graham Bloice (Aug 25)
- Re: Gerrit patches with trailing whitespace Graham Bloice (Aug 25)
- Re: Gerrit patches with trailing whitespace Evan Huus (Aug 25)
- Re: Gerrit patches with trailing whitespace Alexis La Goutte (Aug 25)
- Re: Gerrit patches with trailing whitespace Bill Meier (Aug 25)
- Re: Gerrit patches with trailing whitespace Juan Jose Martin Carrascosa (Aug 25)
- Re: Gerrit patches with trailing whitespace Evan Huus (Aug 25)
- Re: Gerrit patches with trailing whitespace Graham Bloice (Aug 25)
- <Possible follow-ups>
- Re: Gerrit patches with trailing whitespace Peter Kjellerstedt (Aug 26)