Re: [Patch] print-zeromq.c

[François-Xavier Le Bail <fx.lebail () yahoo com>]

> From: Gisle Vanem <gvanem () yahoo no>

> The prototype and implementation of 'zmtp1_print_datagram()'
> is slightly different; the prototype has a 'const u_int len' as the last
> parameter. Whereas the implementation has no 'const'. Hence
> I get a warning from MSVC. Hence:
>
> diff -u3 Git-Latest/print-zeromq.c ./print-zeromq.c
> --- Git-Latest/print-zeromq.c   2014-01-14 17:51:07 +0000
> +++ ./print-zeromq.c    2014-03-01 14:41:53 +0000
> @@ -207,7 +207,7 @@
> }
>
> void
> -zmtp1_print_datagram(const u_char *cp, const u_int len) {
> +zmtp1_print_datagram(const u_char *cp, u_int len) {
>         const u_char *ep = MIN(snapend, cp + len);
>
>         cp = zmtp1_print_intermediate_part(cp, len);


Is it not better to add const in the propotype ?

_______________________________________________
tcpdump-workers mailing list
tcpdump-workers () lists tcpdump org
https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers