Re: [Patch] print-zeromq.c

[François-Xavier Le Bail <fx.lebail () yahoo com>]

> From: Gisle Vanem <gvanem () yahoo no>

> "François-Xavier Le Bail" <fx.lebail () yahoo com> wrote:
>
> >  Is it not better to add const in the propotype ?
>
> Comparing to other print-function with a 'len' as last parameter,
> I think not. Looking through interface.h for *_print() functions, only these
> have a 'const u_int' as last arg:
>   openflow_print, ahcp_print.
>
> IMHO, we should be consistent; a 'const u_int len' or simply a 
> 'u_int len'.
> Some even have a 'register' modifier which seems odd.

I agree that we should be consistent, if possible.
But it's also depend if the parameter is used read-only or not in the function.
_______________________________________________
tcpdump-workers mailing list
tcpdump-workers () lists tcpdump org
https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers