Re: [net-2.6 PATCH] af_packet: move strict addr_len check right

[Eric Dumazet <eric.dumazet () gmail com>]

Le mercredi 03 mars 2010 à 07:40 +0100, Jiri Pirko a écrit :
> Subject: [net-2.6 PATCH] af_packet: move strict addr_len check right before dev_[mc/unicast]_[add/del]
>
> My previous patch 914c8ad2d18b62ad1420f518c0cab0b0b90ab308 incorrectly changed
> the length check in packet_mc_add to be more strict. The problem is that
> userspace is not filling this field (and it stays zeroed) in case of setting
> PACKET_MR_PROMISC or PACKET_MR_ALLMULTI. So move the strict check to the point
> in path where the addr_len must be set correctly.
>
> Signed-off-by: Jiri Pirko <jpirko () redhat com>

I am not sure it solves Pavel Roskin concern, but some credit should be
given to him :)

Reported-by: Pavel Roskin <proski () gnu org>

Thanks


-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.