tcpdump mailing list archives
Re: Current wireless-testing breaks libpcap: mr_alen should be set
From: Jiri Pirko <jpirko () redhat com>
Date: Wed, 3 Mar 2010 07:24:00 +0100
Wed, Mar 03, 2010 at 02:00:48AM CET, proski () gnu org wrote:
Hello! The current wireless-testing appears to have some non-wireless bits from the upcoming Linux 2.6.34. As a result, libpcap and all capture programs that use it are broken. This patch to libpcap helps: --- a/pcap-linux.c +++ b/pcap-linux.c @@ -1563,6 +1563,7 @@ live_open_new(pcap_t *handle, const char memset(&mr, 0, sizeof(mr)); mr.mr_ifindex = handle->md.ifindex; mr.mr_type = PACKET_MR_PROMISC; + mr.mr_alen = 6; if (setsockopt(sock_fd, SOL_PACKET, PACKET_ADD_MEMBERSHIP, &mr, sizeof(mr)) == -1) { libpcap git doesn't have the fix yet. The breakage must be coming from the commit 914c8ad2 by Jiri Pirko to net/packet/af_packet.c I think it's very unhelpful to introduce patches that break significant userspace functionality without giving the affected programs an advance warning. Also, pulling bleeding edge stuff into wireless-testing before rc1 appears to be either a mistake or a bad decision. Sorry for cross-post, but it's an urgent issue. Repliers are encouraged to trim the recipient list as necessary.
Sorry about this. Corrected patch will follow. Jirka
-- Regards, Pavel Roskin
- This is the tcpdump-workers list. Visit https://cod.sandelman.ca/ to unsubscribe.
Current thread:
- Current wireless-testing breaks libpcap: mr_alen should be set Pavel Roskin (Mar 02)
- Re: Current wireless-testing breaks libpcap: mr_alen should be set John W. Linville (Mar 02)
- Re: Current wireless-testing breaks libpcap: mr_alen should be set Jiri Pirko (Mar 02)
- [net-2.6 PATCH] af_packet: move strict addr_len check right before dev_[mc/unicast]_[add/del] Jiri Pirko (Mar 02)
- Re: [net-2.6 PATCH] af_packet: move strict addr_len check right Eric Dumazet (Mar 02)
- Re: [net-2.6 PATCH] af_packet: move strict addr_len check right Jiri Pirko (Mar 03)
- Re: [net-2.6 PATCH] af_packet: move strict addr_len check right David Miller (Mar 03)
- Re: [net-2.6 PATCH] af_packet: move strict addr_len check right David Miller (Mar 03)
- Re: Current wireless-testing breaks libpcap: mr_alen should be set Frank W. Miller (Mar 03)
- Re: Current wireless-testing breaks libpcap: Jiri Pirko (Mar 03)
- Re: Current wireless-testing breaks libpcap: mr_alen should be set Guy Harris (Mar 06)
- Re: Current wireless-testing breaks libpcap: Jiri Pirko (Mar 08)