tcpdump mailing list archives

Re: [PATCH]: pcap and zero copy with requested modification


From: Guy Harris <guy () alum mit edu>
Date: Mon, 5 Jan 2004 23:27:10 -0800

On Tue, Jan 06, 2004 at 03:30:30PM +1300, Jesper Peterson wrote:
Yoann Vandoorselaere wrote:
+        if ( ! alloc_buffer_cb ) {
+                static struct pcap_pkthdr hdr;
+                return &hdr;
+        }

This isn't re-entrant. To allow multithreading and building libpcap as a DLL, 
the default header buffer should probably be in pcap_t.

I agree.

There already *is* one there in 0.8.1 and later - the "pcap_header"
member of a "pcap_t".
-
This is the TCPDUMP workers list. It is archived at
http://www.tcpdump.org/lists/workers/index.html
To unsubscribe use mailto:tcpdump-workers-request () tcpdump org?body=unsubscribe


Current thread: