tcpdump mailing list archives
Re: Re: -e vs. -x, revisited
From: Guy Harris <gharris () sonic net>
Date: Wed, 18 Dec 2002 01:41:59 -0800
On Tue, Dec 17, 2002 at 08:21:39AM -0500, Andrew Brown wrote:
actually, it oughta be simpler than you think. provided that all the functions that may end up being returned from lookup_printer() set packetp and snapend (as it seems they do), then one could simply change default_print_unaligned as follows:
Unfortunately, "default_print()" is used for other purposes - if neither "-x" nor "-q" is specified, the payload of the packet is often printed in hex if it wasn't printed by any dissector, and in that case I suspect the intent is to have it print only the payload, not the link-layer header. (BTW, as per another recent discussioin, that means multi-line output even if "-v" isn't specified....) It also struck me as a bit ugly to make "default_print_unaligned()" ignore its arguments, and use a global variable, if "-e" was specified - and, besides, that global variable no longer exists (I just checked in a change to get rid of "packetp"). So I checked in a change to add a new "default_print_packet()" routine, which takes a pointer to the beginning of the raw packet data (*not* skipping the link-layer header), the number of bytes of raw packet data captured, and the size of the link-layer header; if "-e" is specified, it prints the raw packet data, and if it's not specified, it prints the part of the raw packet data past the link-layer header, if there is any. I also changed the "xxx_if_print()" routines to call that routine if "xflag" is set. - This is the TCPDUMP workers list. It is archived at http://www.tcpdump.org/lists/workers/index.html To unsubscribe use mailto:tcpdump-workers-request () tcpdump org?body=unsubscribe
Current thread:
- Re: New APIs to support multiple DLT_'s on an interface, (continued)
- Re: New APIs to support multiple DLT_'s on an interface Andrew Brown (Dec 16)
- Re: New APIs to support multiple DLT_'s on an interface Andrew Brown (Dec 16)
- Re: New APIs to support multiple DLT_'s on an interface Guy Harris (Dec 17)
- Re: New APIs to support multiple DLT_'s on an interface Andrew Brown (Dec 17)
- Re: New APIs to support multiple DLT_'s on an interface David Young (Dec 16)
- Re: New APIs to support multiple DLT_'s on an interface Guy Harris (Dec 16)
- -e vs. -x, revisited Guy Harris (Dec 17)
- Re: -e vs. -x, revisited Andrew Brown (Dec 17)
- Re: Re: -e vs. -x, revisited Guy Harris (Dec 17)
- Re: Re: -e vs. -x, revisited Andrew Brown (Dec 17)
- Re: Re: -e vs. -x, revisited Guy Harris (Dec 18)
- Re: Re: -e vs. -x, revisited Andrew Brown (Dec 18)
- Re: Re: -e vs. -x, revisited Guy Harris (Dec 18)
- Re: Re: -e vs. -x, revisited Andrew Brown (Dec 18)
- Re: Re: -e vs. -x, revisited Guy Harris (Dec 18)
- Re: Re: -e vs. -x, revisited Michael Richardson (Dec 18)
- Re: Re: -e vs. -x, revisited Guy Harris (Dec 19)
- Re: -e vs. -x, revisited Guy Harris (Dec 18)
- Re: -e vs. -x, revisited Andrew Brown (Dec 18)
- Re: -e vs. -x, revisited Guy Harris (Dec 19)