Re: Completed Lua 5.3 upgrade!

[Patrick Donnelly <batrick () batbytes com>]

Hi Paulino,

On Fri, Jul 15, 2016 at 2:53 PM, Paulino Calderon
<paulino () calderonpale com> wrote:
> I agree with increasing the debug level required to at least 4. A lot of scripts use level 3 to print information and 
> those bin calls are useful but won’t be needed in a lot of cases as they produce a LOT of output.

I reduced it even further in r35999.

> I just spotted another issue with the upgrade to 5.3. lua_tointeger changed behavior in 5.3 
> (https://www.lua.org/manual/5.3/manual.html#lua_tointeger) and it is causing problems with scripts/libraries using 
> explicitly non-specified conversions, specifically i noticed the problem in stdnse.get_timeouts() and 
> comm.setup_connect but I’m posting this to the mailing list in case we use these integer conversions anywhere else:
>
> /Users/cldrn/Tools/nmap/./nselib/comm.lua:65: bad argument #1 to 'set_timeout' (number has no integer representation)
> stack traceback:
>         [C]: in method 'set_timeout'
>         /Users/cldrn/Tools/nmap/./nselib/comm.lua:65: in upvalue 'setup_connect'
>         /Users/cldrn/Tools/nmap/./nselib/comm.lua:211: in function 'comm.opencon'
>         /Users/cldrn/Tools/nmap/./nselib/comm.lua:263: in function 'comm.tryssl'
>         /Users/cldrn/Tools/nmap/./nselib/http.lua:1205: in function </Users/cldrn/Tools/nmap/./nselib/http.lua:1181>
>         (...tail calls...)
>         /Users/cldrn/Tools/nmap/./nselib/http.lua:1625: in function 'http.get'
>         /Users/cldrn/Tools/nmap/./nselib/http.lua:2479: in function 'http.identify_404'
>         /Users/cldrn/Tools/nmap/./scripts/http-enum.nse:370: in function 
> </Users/cldrn/Tools/nmap/./scripts/http-enum.nse:351>
>         (...tail calls...)
>
>
>
> Ps. I’ll post a patch to stdnse later today after I look for this problem in other parts of NSE.

Hopefully this kind of problem isn't too prevelant!

-- 
Patrick Donnelly
_______________________________________________
Sent through the dev mailing list
https://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/