Re: [NSE] IP-HTTPS Discover (Resubmission)

[Gyanendra Mishra <anomaly.the () gmail com>]

Hi,

I often make this mistake of mailing individuals instead of the list :(.
Great to see the changes.
The documentation could use an @usage section, you don't need the return
nil at the end.
Also, http-title has a single line output as well but implements the
xmloutput in a better
manner, you can have a look at it.[1]

Gyani
[1]
https://github.com/takeshixx/ip-https-tools/blob/master/ip-https-discover.nse

On Tue, Aug 25, 2015 at 8:22 PM, Niklaus Schiess <nschiess () adversec com>
wrote:

> Hi Gyanendra,
>
> thanks for your feedback. I've removed the deprecated calls and
> committed them to my repo [0].
>
> If you have any additional suggestions I'm looking forward to implement
> them.
>
> Regards,
> Niklaus
>
> [0]
>
> https://github.com/takeshixx/ip-https-tools/blob/master/ip-https-discover.nse
>
> On 25.08.2015 16:42, Gyanendra Mishra wrote:
> > Hi,
> >
> > Some quick comments, I'll make more soon as I find time.
> > The print_debug calls are deprecated, we have moved onto stdnse.debug1,
> > debug2 .. debug5.
> > You don't have to write the script name in the debug call when using
> debug*.
> > Gyani
> >
> > On Tue, Aug 25, 2015 at 7:03 PM, Niklaus Schiess <nschiess () adversec com>
> > wrote:
> >
> > > Hi,
> > >
> > > this script checks if the IP over HTTPS Tunneling Protocol
> (IP-HTTPS)[1],
> > > developed by Microsoft, is supported. It is very similar to my
> > > sstp-discover script due to various similaritiers of both protocols.
> I've
> > > developed it on a Windows Server 2012 R2 DirectAccess deployment, so
> > > testing is highly appreciated (especially on Windows
> > > Server 2008 deployments).
> > >
> > > Regards,
> > > Niklaus
> > >
> > > [1] http://msdn.microsoft.com/en-us/library/dd358571.aspx
> > >
> > > --
> > > PGP FP: CB84 8C68 ADDB 6C50 7DF1 4227 F2A6 056A A799 76DA
> > >
> > >
> > > _______________________________________________
> > > Sent through the dev mailing list
> > > https://nmap.org/mailman/listinfo/dev
> > > Archived at http://seclists.org/nmap-dev/
>
> --
> PGP FP: CB84 8C68 ADDB 6C50 7DF1 4227 F2A6 056A A799 76DA
_______________________________________________
Sent through the dev mailing list
https://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/