Nmap Development mailing list archives
Re: libdnet OpenBSD compatibility
From: Henri Doreau <henri.doreau () gmail com>
Date: Fri, 17 May 2013 23:35:33 +0200
2013/5/16 David Fifield <david () bamsoftware com>:
On Thu, May 16, 2013 at 09:53:02PM +0200, Henri Doreau wrote:2013/5/11 Giovanni Bechis <giovanni () bigio snb it>:On Fri, May 10, 2013 at 11:22:05AM -0700, David Fifield wrote:On Fri, May 10, 2013 at 02:42:00PM +0200, Giovanni Bechis wrote:Hi, after some changes in our network include files the attached patch is needed to be able to compile the library on OpenBSD.What version of OpenBSD is this? As far as I know, Nmap compiled on recent versions of OpenBSD. I wonder if something changed in libdnet or OpenBSD to make that not be true anymore.in -current SIOCIFNETMASK before SIOCIFADDR will break because of a change, atm we have a local patch for this. GiovanniThe patch looks good to me. For double safety I quickly checked that it doesn't introduce any regression on linux and freebsd. I'd like to commit it. Since it's a libdnet patch, David what's the best way to incorporate it? We (actually, you) de facto maintains libdnet right? Or shall I add it to nmap/libdnet-stripped/ and the NMAP_MODIFICATIONS file?Yes, please commit it to libdnet-stripped and add to NMAP_MODIFICATIONS. I do something like this: git apply patch git add -u git diff --cached >> NMAP_MODIFICATIONS # Edit NMAP_MODIFICATIONS. git commit -a David Fifield
Ok, thanks. I've checked the patch into trunk as of r30900. Thank you Giovanni for the patch. Regards -- Henri _______________________________________________ Sent through the dev mailing list http://nmap.org/mailman/listinfo/dev Archived at http://seclists.org/nmap-dev/
Current thread:
- libdnet OpenBSD compatibility Giovanni Bechis (May 10)
- Re: libdnet OpenBSD compatibility David Fifield (May 10)
- Re: libdnet OpenBSD compatibility Giovanni Bechis (May 11)
- Re: libdnet OpenBSD compatibility Henri Doreau (May 16)
- Re: libdnet OpenBSD compatibility David Fifield (May 16)
- Re: libdnet OpenBSD compatibility Henri Doreau (May 17)
- Re: libdnet OpenBSD compatibility Giovanni Bechis (May 11)
- Re: libdnet OpenBSD compatibility David Fifield (May 10)
- Re: libdnet OpenBSD compatibility Giovanni Bechis (May 11)