Nmap Development mailing list archives
Re: slowloris coding style update
From: Aleksandar Nikolic <nikolic.alek () gmail com>
Date: Sun, 29 Jul 2012 00:05:02 +0200
Thanks for this, that script did need a bit of a cleanup. It had mixed style since I picked up where Ange Gutek left. The code looks good. Aleksandar On 7/27/2012 8:40 PM, Henri Doreau wrote:
Hi, I've reworked http-slowloris.nse a bit to make it closer to our code quality standards. The logic remains the same but I've done many style-related changes which I think make the script easier to read and maintain. Please find the new version attached. Updated: - Consistent variable naming - Default parameters cleanup - removed unused variables (like "local t = nmap.timing_level()") - renamed functions consistently - removed typo from function name ("worker_schedluer") - consistent debug messages format As I said it's only cosmetic, but since the diff is kind of large I'd like someone to have a second look at it. Regards. _______________________________________________ Sent through the nmap-dev mailing list http://cgi.insecure.org/mailman/listinfo/nmap-dev Archived at http://seclists.org/nmap-dev/
_______________________________________________ Sent through the nmap-dev mailing list http://cgi.insecure.org/mailman/listinfo/nmap-dev Archived at http://seclists.org/nmap-dev/
Current thread:
- slowloris coding style update Henri Doreau (Jul 27)
- Re: slowloris coding style update Aleksandar Nikolic (Jul 28)
- Re: slowloris coding style update Henri Doreau (Jul 31)
- Re: slowloris coding style update Aleksandar Nikolic (Jul 28)