Nmap Development mailing list archives
Re: xmpp.nse
From: Henri Doreau <henri.doreau () greenbone net>
Date: Sat, 30 Apr 2011 12:09:11 +0200
Hello, this is a nice script. I've successfully tested it against several xmpp servers. Sounds ok for me, functions should probably be "localized" (defined with local scope modifier) though. I would also replace successive if statements by elseif's in the main loop to avoid performing useless checks. Something like: if tag.name == "starttls" then is_starttls = true elseif tag.name == "required" then ... Another detail: there is no need to supply the specific host.ip field as first argument of connect(), the host table is fine. Regards. -- Henri Doreau | Greenbone Networks GmbH | http://www.greenbone.net Neuer Graben 17, 49074 Osnabrueck, Germany | AG Osnabrueck, HR B 202460 Executive Directors: Lukas Grunwald, Dr. Jan-Oliver Wagner _______________________________________________ Sent through the nmap-dev mailing list http://cgi.insecure.org/mailman/listinfo/nmap-dev Archived at http://seclists.org/nmap-dev/
Current thread:
- xmpp.nse Vasiliy Kulikov (Apr 17)
- Re: xmpp.nse David Fifield (Apr 18)
- Re: xmpp.nse David Fifield (Apr 18)
- Re: xmpp.nse Vasiliy Kulikov (Apr 21)
- Re: xmpp.nse Henri Doreau (Apr 30)
- Re: xmpp.nse Vasiliy Kulikov (May 04)
- Re: xmpp.nse Henri Doreau (May 07)
- Re: xmpp.nse Vasiliy Kulikov (May 08)
- Re: xmpp.nse Vasiliy Kulikov (May 15)
- Re: xmpp.nse Henri Doreau (May 22)
- Re: xmpp.nse Vasiliy Kulikov (May 22)
- Re: xmpp.nse Vasiliy Kulikov (Apr 21)
- Re: xmpp.nse Vasiliy Kulikov (May 08)