Nmap Development mailing list archives
RE: Version display patch
From: Rob Nicholls <robert () robnicholls co uk>
Date: Tue, 08 Feb 2011 17:29:08 +0000
This is just a personal preference, but could the "Compiled without:" line be omitted if it's otherwise blank?
Rob On Tue, 8 Feb 2011 11:10:24 -0600, Thomas Buchanan wrote:
Yes, I can confirm that the latest patch compiles and links correctly onmy system. Here is the output from the resulting nmap binary: $ NMAPDIR=. ./nmap --version Nmap version 5.51SVN ( http://nmap.org ) Platform: i686-pc-windows-windows Compiled with: liblua-5.1.3 openssl-1.0.0a libpcre-7.6 libpcap-4.1.2 libdnet-1.12 ipv6 Compiled without: Thanks, Thomas-----Original Message----- From: ambarisha b [mailto:b.ambarisha () gmail com] Sent: Tuesday, February 08, 2011 10:57 AM To: Thomas Buchanan; nmap-dev () insecure org Subject: Re: Version display patch That's a linker error.pcap_version was not from the external interface.In windows ,may be that internal library file isn't linked with nmap.cc.Anyway I have removed the pcap_version and added pcap_lib_version() which is part of the external interface.I setup a windows test environment and it compiled fine.I have attached the updated patch. Thomas, can you confirm this ? Thanks. Regards Ambarisha On Mon, Feb 7, 2011 at 8:19 AM, Thomas Buchanan <TBuchanan () thecompassgrp net> wrote: >> -----Original Message----- >> From: ambarisha b [mailto:b.ambarisha () gmail com] >> Sent: Sunday, February 06, 2011 2:40 PM >> To: Thomas Buchanan; nmap-dev () insecure org >> Subject: Re: Version display patch >>>> David, thanks for the revised patch.I have attached the patch after>> making the changes that you pointed out. >> >> Thomas, thanks for pointing that out.Can you post the error you got on >> including dnet_winconfig.h ? >> >> Regards >> Ambarisha >> >> I tried the updated patch you attached, but with the following line:> > #include "libdnet-stripped/include/config.h" > > Changed to: > > #include "libdnet-stripped/include/dnet_winconfig.h" > > This time I didn't get a compile error with dnet_winconfig.h, but did > get the following linking error:> 4>nmap.obj : error LNK2001: unresolved external symbol "char const *> const pcap_version" (?pcap_version@@3QBDB) > 4>.\Release/nmap.exe : fatal error LNK1120: 1 unresolved externals > > Any ideas? > > Thanks, > > Thomas >_______________________________________________ Sent through the nmap-dev mailing list http://cgi.insecure.org/mailman/listinfo/nmap-dev Archived at http://seclists.org/nmap-dev/
_______________________________________________ Sent through the nmap-dev mailing list http://cgi.insecure.org/mailman/listinfo/nmap-dev Archived at http://seclists.org/nmap-dev/
Current thread:
- Re: Version display patch, (continued)
- Re: Version display patch Jan-Oliver Wagner (Jan 31)
- Re: Version display patch David Fifield (Feb 01)
- Re: Version display patch ambarisha b (Feb 02)
- Re: Version display patch ambarisha b (Feb 04)
- Re: Version display patch David Fifield (Feb 04)
- RE: Version display patch Thomas Buchanan (Feb 04)
- Re: Version display patch ambarisha b (Feb 06)
- RE: Version display patch Thomas Buchanan (Feb 06)
- Re: Version display patch ambarisha b (Feb 08)
- RE: Version display patch Thomas Buchanan (Feb 08)
- RE: Version display patch Rob Nicholls (Feb 08)
- Re: Version display patch ambarisha b (Feb 08)
- Re: Version display patch David Fifield (Feb 08)
- Version display: included vs. system libraries David Fifield (Feb 09)
- Re: Version display: included vs. system libraries Kris Katterjohn (Feb 09)
- Re: Version display: included vs. system libraries ambarisha b (Feb 09)
- Re: Version display: included vs. system libraries Kris Katterjohn (Feb 09)
- Re: Version display: included vs. system libraries David Fifield (Feb 18)
- Re: Version display: included vs. system libraries ambarisha b (Feb 19)
- Re: Version display: included vs. system libraries ambarisha b (Feb 22)
- Re: Version display: included vs. system libraries David Fifield (Feb 24)