Nmap Development mailing list archives
Re: NSE: RMI Dumpregistry
From: David Fifield <david () bamsoftware com>
Date: Tue, 23 Nov 2010 09:49:02 -0800
On Tue, Nov 23, 2010 at 08:54:27AM +0100, Martin Holst Swende wrote:
On 11/23/2010 12:23 AM, David Fifield wrote:On Sun, Nov 21, 2010 at 09:02:18PM +0100, Martin Holst Swende wrote:On 11/17/2010 01:54 PM, Martin Holst Swende wrote:On 11/17/2010 01:43 PM, Patrick Donnelly wrote:On Tue, Nov 2, 2010 at 7:37 PM, Patrick Donnelly <batrick () batbytes com> wrote:On Mon, Nov 1, 2010 at 4:52 PM, David Fifield <david () bamsoftware com> wrote:Sorry again for the delay. I added the library and script using the files from your branch.There is a minor problem with the rmi library: batrick@batbytes:~/nmap/svn/nmap$ ./nse_check_globals [...] Checking nselib/rmi.lua for bad global accesses Found indexed global,'peekUnpack', at line number 198. Found indexed global,'p', at line number 1179. [...] I fixed peekUnpack but don't know what to do with the second one, 'p'.Poking this thread since this problem still exists.Poke taken :) Sorry for the delay, will try do get some NSE-work done this weekend. /MartinI have now made some changes to rmi-dumpregistry, so that the small bugs with global accesses are fixed, the verbosity is lessened and I have made some changes to the documentation - which was not previously done according to nse-practices of triple-dash "---". There should be a whole lot more that is shown on the nsedoc portal now. Changes can be fetched from http://martin.swende.se/hg/nsescriptsI think your hg branch is missing some revisions from the SVN trunk. Anyway if I try to merge the changes they don't apply cleanly: $ hg diff -r 47:49 ~/branches/nsescripts | patch -p1 patching file nselib/rmi.lua Hunk #7 FAILED at 177. Hunk #8 FAILED at 229. 2 out of 33 hunks FAILED -- saving rejects to file nselib/rmi.lua.rej patching file scripts/rmi-dumpregistry.nse Hunk #1 FAILED at 1. Hunk #2 succeeded at 29 (offset 3 lines). Hunk #3 FAILED at 136. 2 out of 4 hunks FAILED -- saving rejects to file scripts/rmi-dumpregistry.nse.rej I tried using hgsubversion to merge the changes but I couldn't find a way to do it because the branches are unrelated. Please incorporate the changes that have happened since the RMI code was added and then I'll merge your changes. David FifieldI updated my nmap installation from the 5.36TEST2-source, so any changes there are included (there was a e.g. a category-addition and your global-access fix in the library). With hindsight, of course I should have imported those, and then made a commit, so it would have been easier for you to follow. Do you want me to import the changes in a branch at rev 47 and merge with the current head?
I think I see what you did. Yes, I was confused. I copied the files and looked at the diffs and everything looked right, so you had already done what I was asking you to do. I guess your merge from SVN was done as part of your r48. I committed the new files. David Fifield _______________________________________________ Sent through the nmap-dev mailing list http://cgi.insecure.org/mailman/listinfo/nmap-dev Archived at http://seclists.org/nmap-dev/
Current thread:
- Re: NSE: RMI Dumpregistry David Fifield (Nov 01)
- Re: NSE: RMI Dumpregistry Martin Holst Swende (Nov 02)
- Re: NSE: RMI Dumpregistry David Fifield (Nov 02)
- Re: NSE: RMI Dumpregistry Patrick Donnelly (Nov 02)
- Re: NSE: RMI Dumpregistry Patrick Donnelly (Nov 17)
- Re: NSE: RMI Dumpregistry Martin Holst Swende (Nov 17)
- Re: NSE: RMI Dumpregistry Martin Holst Swende (Nov 22)
- Re: NSE: RMI Dumpregistry David Fifield (Nov 22)
- Re: NSE: RMI Dumpregistry Martin Holst Swende (Nov 22)
- Re: NSE: RMI Dumpregistry David Fifield (Nov 26)
- Re: NSE: RMI Dumpregistry Patrick Donnelly (Nov 17)
- Re: NSE: RMI Dumpregistry Martin Holst Swende (Nov 02)