Re: Status Report for Drazen #14 of 16

[Daniel Miller <bonsaiviking () gmail com>]

Dražen,

Your Perl (not PERL!) looks pretty good to me. I attached a diff that is 
entirely comments, so you can see a bit how I would have written the 
same code. Pay particular attention to the usage of the 3-argument form 
of open: it can cause some nasty security bugs if it's not used.

Looking forward to seeing the final product!

Daniel

On 08/03/2010 08:29 AM, Dražen Popović wrote:
> Hi all.
>
> Accomplishments:
>        * Started working on PIDL module which will generate MSRPC code
>          for NSE. For now it generates interface definitions, structures
>          and typedefs. What's left is to generate the actual stubs.
>        * Contacted SAMBA developer Jelmer Vernooij which maintains PIDL
>          and other MSRPC stuff that SAMBA uses. He gave me a few useful
>          tips and advices.
> Priorities:
>        * Finish the stub generation and start testing the generated
>          clients. There is a possibility of automatically generating test
>          cases for generated stubs. This would consist of generating RPC
>          function calls with some predefined values and generating RPC
>          server code much like MIDL_BENCH/DRAZEN_SVC RPC service. But
>          this is a lower priority.
> Notes:
> PIDL is written in PERL which gave me a headache during our first
> encounter. With all its nasty syntax and lack of code documentation it
> took me a while to hack it. Know I see that PIDL is pretty well
> programmed as it offers me a way of generating msrpc code with ease. For
> all you PERL dudz out there I would very much like to here some
> criticism considering my perl programming. I checked out PIDL from
> SAMBAs GIT repository and copied it into my "nmap-exp/drazen" directory.
> So one can download the  current NMAP module for PIDL from:
> svn://svn.insecure.org/nmap-exp/drazen/var/PIDL
>
>
> Cheers,
> Dražen.
>

Attachment: pidl-critique.diff
Description:

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/