Re: NMAP NSE script for iSCSI enumeration

[David Fifield <david () bamsoftware com>]

On Sun, Oct 11, 2009 at 01:43:05AM -0400, Michel Chamberland wrote:
> Thanks again everyone for your input! 
>
> I've updated the script following your suggestions and uploaded it at
> same URL. It is quite easier to read now. The process of documenting it
> also allowed me to remove the whole first packet after I realized it was
> not required :) Now I'll see if I can get some more testing done with
> various targets... 

Going by the criteria at
http://nmap.org/book/nse-usage.html#nse-categories , would you consider
the script "safe" or "intrusive"? I'm guessing it is safe because you
have it in default.

In shortport.port_or_service(3260, "iSCSI"), I think you want to use
"iscsi" because that is the capitalization used in the nmap-services
file.

There's a call to nmap.new_try but the try object isn't used anywhere.
Maybe it's left over from a pervious version?

I would remove "iSCSI Targets found" from the output. That will be clear
enough because the script name will be printed.

Please add an NSEDoc @usage section. It can be just like you have on
your blog page.

Thanks for writing the script! What software are you running on
localhost that provides the iSCSI service? What kinds of devices is it
likely to be found on?

David Fifield

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org