Re: ncat/sys_wrap.c

[Kris Katterjohn <katterjohn () gmail com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/06/2009 05:59 PM, Fyodor wrote:
> On Tue, Jan 06, 2009 at 01:20:59PM -0600, Kris Katterjohn wrote:
> > On 01/06/2009 08:19 AM, Gisle Vanem wrote:
> > > Why do we need to override vsscanf() like in
> > > sys_wrap.c? The _asm statements in this file is
> > > only good for MSVC. What about MIngW?
> > I'm not sure why it's needed, but I tracked down its origins to Mixter's r8439
> > with the log message "Fix win32 portability issues".  I'm not sure if he was
> > testing with VC++2008 during this commit, but judging by the other SVN logs he
> > may have been trying to.  I'll try to look into whether this is needed at all.
>
> Thanks Kris.  With your Ncat VC++ successes last summer, this may no
> longer be needed at all.  It looks like the "vsscanf" with the
> assembly code is only used by "Sscanf" in the same file.  But we
> should probably remove that and the rest of sys_wrap.* and use the
> same portability methods used in the rest of Nmap.  Visual C++ seems
> to have the normal sscanf() anyway since we seem to already be using
> it in other parts of Nmap and I don't see any nbase redefinition.
>
> If you have time to try to remove the sys_wrap* stuff, that would be
> great.

I had actually wanted to remove all of that cruft during the summer but never
got around to discussing it with you and nmap-dev.  I'll certainly try to take
care of it.

> Cheers,
> -F

Thanks,
Kris Katterjohn

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iQIcBAEBAgAGBQJJZA7BAAoJEEQxgFs5kUfuhSAP/0z9CKNO7DyZokV0NnxnlIc3
aItD59wzvsnGTrS/KmovZE1IGMyrAdwYe+Ku2wY/Gq12P245y6h6mHePJPqeHTZL
CizC2RLkGCGN/mMJuR9UTDHbjnrLCQIP1W1jMH4EM/TiK0274eXkBpRm34UODdxe
YsJUJb5GVmYGGvPurEgH4PotedmG5PrtTzZ+NuZJomIE89mMVcHs+zr6+ahFx9v5
FOrnJwGSwMLJb44RUsFLK8+O+wPReHkW7pXCooGEMFAqoi0i1bGLU5SkYYNLi3iR
Os0E2A3OIX3Peon9YluE1bgDMfh8NqbrrEAlT/LFc4qOjTgohC1bhrs1bj82DJmG
8Nqe776hdzg5LqdIwQzTR4ZgSKivD2uKCm0h6dMUzpBUeq+AlGi9AyZaoCbjxF7D
i9mW9aVPyKfFy4pLDvIAkXmsEBdSjn6McHM6gd6QOpMnS4Y1dbBOFIz/oJ4PELGM
4Upt4ikuLfA/yqab9S9KI2a0e1fCSoHMSbHFjuXlgVz7YV9C5LHHlcM2TfpHoa8k
ir7YYsqTBv1TvXoZb4V8DTuU4w2Of2asMNekw+2/yih6faNX9d+qHCRoaHGqLYis
I8UsXkuxdZ6qYOsQQ/QcHwKZVr2GA3/7iFS0vgsLmpMENzOehTajV6NQm4k/I8RH
cWrQub1oZ5tYi7fW2r9t
=zzfN
-----END PGP SIGNATURE-----

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org