Nmap Development mailing list archives
Re: ncat/sys_wrap.c
From: Kris Katterjohn <katterjohn () gmail com>
Date: Tue, 06 Jan 2009 13:20:59 -0600
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 01/06/2009 08:19 AM, Gisle Vanem wrote:
Why do we need to override vsscanf() like in sys_wrap.c? The _asm statements in this file is only good for MSVC. What about MIngW?
I'm not sure why it's needed, but I tracked down its origins to Mixter's r8439 with the log message "Fix win32 portability issues". I'm not sure if he was testing with VC++2008 during this commit, but judging by the other SVN logs he may have been trying to. I'll try to look into whether this is needed at all.
I fail to see why we can't simply do: --- SVN-Latest\ncat\sys_wrap.c Wed Dec 24 13:31:15 2008 +++ ncat\sys_wrap.c Tue Jan 06 14:57:58 2009 @@ -5,7 +5,7 @@ #include "sys_wrap.h" #include "util.h" -#ifdef WIN32 +#if defined(WIN32) && !defined( __GNUC__) int vsscanf( const char *buffer,
So this allows Ncat to compile with Mingw and VC++? If so I'll commit it; if not, let us know how much more is needed for Mingw and we can make one commit rather than several.
--gv
Thanks, Kris Katterjohn -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iQIcBAEBAgAGBQJJY68VAAoJEEQxgFs5kUfuAPUP/2OmxN7blm/Ig7k8x5uu2zF0 KunhdU1BkTZgw7n5rc73Y15A10yAHvvxlbMikB+mX4EaD8WEr6ufqCzmpx0YdCV9 eJ4OS3SuCNy+HRge3i2bQKo540LxVHH56lGsHXDwcog3qhMBDwvZ+ltHRQjjLL4B KRFOfICMo1agk5ZlPCjIt8qyAySndEw1mw56qggcmupg6ax32pU9bItaNff+CBKR LmAWqVBEqEvY3mzQZSqXZeDUXA9oskvJpyFfrLmv+fdAxsWYdCzC2uhwOAjXM7xf ZQDIZHlSoSZLcuIsreFNtjeY3UUyO2mAg5InNz0fWngJfYNIhSg+Iaatimgj6+0z 9peZG7muGLAkWC13htBTuZjvyoRSMFcD8aPUKzIY7vmJoJd6cFpfD8Q5PV9kQtiE qrsoo93nXiuqKJPqutkebEya2Lh6qQRhsTT73yLLBwcsAPo4DA9oftlRx+UzBtCx 1yczw/6vFEqFe5Kxz6NWPw2LbFfFY3e+mFQjwoYLXlK/haVAXVy3RQyuBzol5hOq xHTRyTBYGxFYDoR0hN/Z2J7Cn9F8R5iMUSEEMLvXXPIM3Bcwaa5RQ/3gDT2jWT2W 9pgFH+qFd5CT1s4WHPCOS+HJL+QbW+0Qa4WvdJ2ujW7OR4TnpEBb81Yc2CFNTDgr yqCAxevb7FQ4mxYiVxax =E5M2 -----END PGP SIGNATURE----- _______________________________________________ Sent through the nmap-dev mailing list http://cgi.insecure.org/mailman/listinfo/nmap-dev Archived at http://SecLists.Org
Current thread:
- ncat/sys_wrap.c Gisle Vanem (Jan 06)
- Re: ncat/sys_wrap.c Kris Katterjohn (Jan 06)
- Re: ncat/sys_wrap.c Fyodor (Jan 06)
- Re: ncat/sys_wrap.c Kris Katterjohn (Jan 06)
- Re: ncat/sys_wrap.c Fyodor (Jan 06)
- Re: ncat/sys_wrap.c Kris Katterjohn (Jan 06)