Nmap Development mailing list archives
Re: [PATCH] Bugfix to random target generation
From: Fyodor <fyodor () insecure org>
Date: Sun, 30 Nov 2008 12:51:43 -0800
On Sun, Nov 23, 2008 at 12:41:35PM +0000, Jack Grahl wrote:
The patch below fixes what appears to be an error in the function ip_is_reserved(). The test which has been removed returns true for all IP addresses of the form *.255.255.255. Either this is a logical error and the intention was to remove 255.255.255.255 as the comment seems to indicate, or it was intended to remove all these addresses.
Hi Jack. Good point. I've removed the *.255.255.255 addresses from ip_is_reserved() as you suggest. I also removed this: /* believe it or not, 204.152.64.0/23 is some bizarre Sun proprietary * clustering thing */ if (i1 == 204 && i2 == 152 && (i3 == 64 || i3 == 65)) return 1; That has been there more than 6 years and there is no guarantee that the supposed issue still exists or (even if it does) that it will in the future. If someone knows a good reason to filter out these addresses, speak up. Otherwise I'll leave them out of the function (and thus allow their selection during -iR). Cheers, -F _______________________________________________ Sent through the nmap-dev mailing list http://cgi.insecure.org/mailman/listinfo/nmap-dev Archived at http://SecLists.Org
Current thread:
- [PATCH] Bugfix to random target generation Jack Grahl (Nov 23)
- Re: [PATCH] Bugfix to random target generation David Fifield (Nov 26)
- Re: [PATCH] Bugfix to random target generation Fyodor (Nov 30)
- Re: [PATCH] Bugfix to random target generation jah (Nov 30)