Nmap Development mailing list archives

Re: [PATCH] Dramatically reduce # of fopen()s and fclose()s in nbase_rnd.c

From: Fyodor <fyodor () insecure org>
Date: Fri, 15 Dec 2006 16:34:10 -0800

On Fri, Dec 15, 2006 at 11:43:38AM -0600, Kris Katterjohn wrote:

This simple patch dramatically reduces the number of fopen()s and
fclose()s used when getting random numbers from nbase_rnd.c by keeping
the rng device open.


It seems like a tough call, since keeping file descriptors open has
its own problems.  Particularly since Nmap often uses so many
concurrently anywa.  Have you measured how much time the 512 opens
take up?  Do you see any performance difference from your patch?

Cheers,
-F

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org

Current thread:

[PATCH] Dramatically reduce # of fopen()s and fclose()s in nbase_rnd.c Kris Katterjohn (Dec 15)
- Re: [PATCH] Dramatically reduce # of fopen()s and fclose()s in nbase_rnd.c Fyodor (Dec 15)
  - Re: [PATCH] Dramatically reduce # of fopen()s and fclose()s in nbase_rnd.c Kris Katterjohn (Dec 15)
- Re: [PATCH] Dramatically reduce # of fopen()s and fclose()s in nbase_rnd.c Dmitry V. Levin (Dec 15)
  - Re: [PATCH] Dramatically reduce # of fopen()s and fclose()s in nbase_rnd.c Kris Katterjohn (Dec 16)