Re: Fix for WinPcap 3.1

["Gisle Vanem" <giva () bgnett no>]

"Andy Lutomirski" <luto () stanford edu> said:

> I don't love this test for Unicode -- it will false-positive if there is 
> a single-character name and will probably overread the buffer.  If 
> anyone knows a clean way to find winpcap's version, that would help. 

I said it was an easy fix :-)  Besides 'pcaplist' never have single-character 
names. You did the same test in winip_init_pcap():
  char *foobar = a[1] ? "%s\n" : "%S\n";

The correct thing to do would probably be to ignore the OS-version and 
use IsTextUnicode() on the returned names.

--gv


---------------------------------------------------------------------
For help using this (nmap-dev) mailing list, send a blank email to 
nmap-dev-help () insecure org . List archive: http://seclists.org