Failed pipeline for nvmeof_getlog_page | wireshark | 3a8e09ef

["Constantine Gavrilov" <CONSTG () il ibm com>]

I have a question regarding for a special form of automatic builds that I 
do not understand.

Occasionally, I get an email for additional pipeline build that is 
different from default pipeline linked to the ticket. It is a wider set of 
compilers and distributions.

Several questions:
What is the significance of this and when it is triggered?
Why it is not linked to MR (meaning I cannot see this failure in MR)?
Shall I fix these failures?
How do I know that the issue is fixed, since such builds are not linked to 
MR?

I have looked at this particular one, and it is a a bug in compiler:

guint64 off =...; /* take from command context, now looking at reply */
if (off < 40)
        proto_add_item(...., .... 40-off,.....);

So, the error (in CLANG-11) is (40-off) is 64-bit and passing it as 32-bit 
parameter "looses high-order bits".

First, the compiler shall see that no loss of value takes place because of 
the "IF" statement here. Second, since when passing 64-bit value as a 
32-bit parameter shall be a compiler error in C language?

I can easily fix this (check the value in saved context, and if it is 
above possible payload length return, then declare off as 32-bit), but I 
need to know if CLANG-11 (with draconian compile options) is a MUST to 
pass. 


-
----------------------------------------
Constantine Gavrilov
Storage Architect
Master Inventor
Tel-Aviv Storage Lab IDT Lead
Tel-Aviv IBM Storage Lab
1 Azrieli Center, Tel-Aviv
----------------------------------------
----- Forwarded by Constantine Gavrilov/Israel/IBM on 03/31/2021 10:07 AM 
-----

From:   GitLab <gitlab () mg gitlab com>
To: 
Date:   03/30/2021 05:37 PM
Subject:        [EXTERNAL] Failed pipeline for nvmeof_getlog_page | 
wireshark | 3a8e09ef
Sent by:        gitlab () mg gitlab com



Pipeline #278885577 has failed!   Project Constantine Gavrilov / wireshark 
Branch nvmeof_getlog_page Commit 
‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍






Pipeline #278885577 has failed! 

 

Project
Constantine Gavrilov / wireshark 
Branch


nvmeof_getlog_page 

Commit


3a8e09ef 
NVMe: Get LogPage: Commands Supported and Effects 
Commit Author


Constantine Gavrilov 


 

Pipeline #278885577 triggered by 

Constantine Gavrilov 

had 1 failed build. 
Failed builds 



build 

clang-11 




You're receiving this email because of your account on gitlab.com. Manage 
all notifications · Help 




___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe