Re: Error while building Windows installer

[Graham Bloice <graham.bloice () trihedral com>]

The CMakeLists changes check for VS 16 (2019) onwards to set the flags.

As our CI doesn't do rebuilds, this issue (if it is due to the new flags)
would only be noticed by devs.

Will you raise an issue for it so at least we can get a discussion on what
to do?

On Fri, 2 Jul 2021 at 13:23, Martin Mathieson via Wireshark-dev <
wireshark-dev () wireshark org> wrote:

> Reverting that change for me meant that I can run Wireshark.exe and create
> the NSIS installer.
> I don't know if we should make this an option, or tighten up the version
> check to MSVC builds it is known to work for?
>
> P.S.  I have become a little bit screenshot-happy lately :)
>
>
>
>
> On Fri, Jul 2, 2021 at 11:59 AM Graham Bloice <graham.bloice () trihedral com>
> wrote:
>
> > I noticed this yesterday on my first build for a while and implemented a
> > quick workaround by adding "/t:Rebuild" to the msbuild command line to
> > force a rebuild of the world. Obviously not supportable for continued use.
> >
> > I haven't had time to go back and look into the issue, my first
> > suspicion is something to do with MR 3329
> > <https://gitlab.com/wireshark/wireshark/-/merge_requests/3329>, but I
> > don't have anything to back that up.
> >
> > P.S. CMD supports (and has for a long time) copy and paste of the text so
> > no need for an image.  Highlight the text with the mouse and Ctrl + C or
> > Enter.  Works in PowerShell as well, Windows Terminal is different (sigh)
> > and only supports Ctrl + Shift + C.
> >
> > On Fri, 2 Jul 2021 at 10:31, Martin Mathieson via Wireshark-dev <
> > wireshark-dev () wireshark org> wrote:
> >
> > > I am getting this error while running:
> > >
> > > msbuild /m /p:Configuration=RelWithDebInfo nsis_package_prep.vcxproj
> > >
> > >
> > > [image: image.png]
> > >
> > > The build itself succeeds, but the resulting Wireshark.exe won't run:
> > >
> > > [image: image.png]
> > >
> > > I haven't bisected to see where it first went wrong... has anyone else
> > > seen this problem?
> > >
> > > Regards,
> > > Martin
> > >
> > >
> > >
> > >
> > >
> > > ___________________________________________________________________________
> > > Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> > > Archives:    https://www.wireshark.org/lists/wireshark-dev
> > > Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
> > >              mailto:wireshark-dev-request () wireshark org
> > > ?subject=unsubscribe
> >
> >
> > --
> > Graham Bloice
> >
> > ___________________________________________________________________________
> > Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> > Archives:    https://www.wireshark.org/lists/wireshark-dev
> > Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
> >              mailto:wireshark-dev-request () wireshark org
> > ?subject=unsubscribe
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> Archives:    https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-request () wireshark org
> ?subject=unsubscribe


-- 
Graham Bloice

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe