Wireshark mailing list archives

Next steps after submitting a dissector?


From: Daniel Dulaney <dulaney.daniel () gmail com>
Date: Wed, 7 Apr 2021 18:17:12 -0400

Hi,

I recently submitted a pull request for a TIFF image dissector (in
!2640). It was originally written to help with troubleshooting a
proprietary industrial camera protocol, but I fleshed it out and
decided to submit it. After reviewing doc/README.dissector, it looks
like there are a few things that I should do to help test and document
it, but I have a couple of questions:

- I requested access to create a Wiki page for the file format. Should
I wait until the PR is accepted or edit the Wiki as soon as I get
access to it?
- I ran fuzz testing on a sample capture file. Are there any other
tests I should add?
- My sample capture file is an HTTP transaction that includes some
packets beyond the basic TIFF data. Is that acceptable, or should I
strip out anything not relevant?
- Can I submit additional "raw" TIFF files (i.e. not pcaps) that can
be opened with the MIME_FILE dissector?

Thanks for any help!
Dan

-- 
Daniel Dulaney
202-577-3242
dulaney.daniel () gmail com
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

Current thread: