Re: pfcp ctag decode bug

[Ranjeet kumar singh <ranjeetsih () gmail com>]

I tested Wireshark-win64-3.3.0rc0-2029-g272502790bf1.msi.
It's working fine.

Thanks a lot.

Regards
Ranjeet S



On Sat, Sep 12, 2020 at 10:25 PM Pascal Quantin <pascal () wireshark org> wrote:
> Hi Ranjeet,
>
> Le sam. 12 sept. 2020 à 18:45, Ranjeet kumar singh <ranjeetsih () gmail com> a écrit :
> > PFA wireshark file.
>
>
> Thanks. The current MR gives the following decoding:
> C-TAG :
>     IE Type: C-TAG (134)
>     IE Length: 3
>     Flags: 0x04, VID
>         0000 0... = Spare: 0
>         .... .1.. = VID: True
>         .... ..0. = DEI: False
>         .... ...0 = PCP: False
>     0000 .... 1100 1000 = C-VID: 0x00c8
>     .... 0... = Drop eligible indicator (DEI): Ineligible
>     .... .000 = Priority code point (PCP): Best Effort (default), Drop Eligible (0)
>
> Best regards,
> Pascal.
>
> > Regards
> > Ranjeet S
> >
> > On Sat, Sep 12, 2020 at 9:31 PM Pascal Quantin <pascal () wireshark org> wrote:
> > > Hi Ranjeet,
> > >
> > > Le sam. 12 sept. 2020 à 17:58, Ranjeet kumar singh <ranjeetsih () gmail com> a écrit :
> > > > Hi Pascal
> > > >
> > > > Please find the attached image that shows the byte dump of the c-tag IE.
> > >
> > >
> > > Please provide a full packet if you want the bug to be fixed. Thanks for your understanding.
> > >
> > > > Regards
> > > > Ranjeet Singh
> > > >
> > > > On Sat, Sep 12, 2020 at 9:08 PM Pascal Quantin <pascal () wireshark org> wrote:
> > > > > Hi Ranjeet,
> > > > >
> > > > > Le sam. 12 sept. 2020 à 10:16, Pascal Quantin <pascal () wireshark org> a écrit :
> > > > > > Le sam. 12 sept. 2020 à 04:40, Guy Harris <gharris () sonic net> a écrit :
> > > > > > > On Sep 11, 2020, at 7:04 PM, Ranjeet kumar singh <ranjeetsih () gmail com> wrote:
> > > > > > >
> > > > > > > > I am seeing following error
> > > > > > > >
> > > > > > > > [Dissector bug, protocol PFCP:
> > > > > > > > C:\buildbot\builders\wireshark-3.2-64\windows-2019-x64\build\epan\proto.c:11594:
> > > > > > > > field pfcp.c_tag.dei_flag is not of type FT_CHAR or an FT_{U}INTn
> > > > > > > > type]
> > > > > > > >
> > > > > > > > with a pfcp session establishment request.
> > > > > > > >
> > > > > > > > Can someone please confirm if it is a bug.
> > > > > > >
> > > > > > > Yes, Wireshark confirmed it, by saying "Dissector bug".  That's what the "bug" in "Dissector bug" means.
> > > > > > >
> > > > > > > The right place to report Wireshark bugs is
> > > > > > >
> > > > > > >         https://gitlab.com/wireshark/wireshark/-/issues
> > > > > >
> > > > > >
> > > > > > See https://gitlab.com/wireshark/wireshark/-/merge_requests/227
> > > > > >
> > > > > > I still have a doubt regarding the C-VID / S-VID encoding. See the MR comment for more details.
> > > > >
> > > > >
> > > > > it would be great if you could share a pcap containing a packet with a C-TAG or S-TAG IE so as to verify the 
> > > > > fix.
> > > > >
> > > > > Thanks,
> > > > > Pascal.
> > > > > ___________________________________________________________________________
> > > > > Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> > > > > Archives:    https://www.wireshark.org/lists/wireshark-dev
> > > > > Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
> > > > >              mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
> > > > ___________________________________________________________________________
> > > > Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> > > > Archives:    https://www.wireshark.org/lists/wireshark-dev
> > > > Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
> > > >              mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
> > >
> > > ___________________________________________________________________________
> > > Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> > > Archives:    https://www.wireshark.org/lists/wireshark-dev
> > > Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
> > >              mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
> > ___________________________________________________________________________
> > Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> > Archives:    https://www.wireshark.org/lists/wireshark-dev
> > Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
> >              mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
>
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> Archives:    https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe