Re: Gitlab doesn't show all epan/dissectors/ files.

[Graham Bloice <graham.bloice () trihedral com>]

On Fri, 11 Sep 2020 at 12:47, Joakim Karlsson <oakimk () gmail com> wrote:

> Maybe it's time to split .h and .c files
>
> /include
> /src
>
> //Joakim
Apart from the oddness of altering our code layout due to the
inadequacies of the review platform, there are nearly 1500 .c files so that
won't fix the issue.



> On Wed, 9 Sep 2020 at 23:50, chuck c <bubbasnmp () gmail com> wrote:
>
> > It's not all bad. I've gotten much better at navigating the code using
> > VSCode since the migration.
> > :-)
> >
> >
> > On Wed, Sep 9, 2020 at 4:27 PM Graham Bloice <graham.bloice () trihedral com>
> > wrote:
> >
> > > On Wed, 9 Sep 2020 at 19:44, Maynard, Chris via Wireshark-dev <
> > > wireshark-dev () wireshark org> wrote:
> > >
> > > > It doesn’t seem to be possible to list all dissectors in a web browser
> > > > anymore, and those that are listed are populated very slowly.
> > > > Compare the loading of
> > > > *https://gitlab.com/wireshark/wireshark/-/tree/master/epan/dissectors*
> > > > <https://gitlab.com/wireshark/wireshark/-/tree/master/epan/dissectors>
> > > > with that of
> > > > *https://code.wireshark.org/review/gitweb?p=wireshark.git;a=tree;f=epan/dissectors;h=18070dacc9b477c446503e46b68b3c128d1ae984;hb=HEAD*
> > > > <https://code.wireshark.org/review/gitweb?p=wireshark.git;a=tree;f=epan/dissectors;h=18070dacc9b477c446503e46b68b3c128d1ae984;hb=HEAD>
> > > > .
> > > >
> > > > I was interested in looking at packet-ntp.c, but that file never gets
> > > > listed, even after clicking *“Show more”*.   The last file listed for
> > > > me is packet-newmail.c. Tested with Firefox 80.0.1 (64-bit) and Chrome Version
> > > > 85.0.4183.102 (Official Build) (64-bit).  Of course if you know the
> > > > filename, you can click on another file then manually edit the URL with the
> > > > file you’re actually interested in looking at, but this isn’t an ideal
> > > > solution.
> > > >
> > > > Is anyone else experiencing this problem?  And more importantly, is
> > > > there anything that can be done to remedy this?
> > > > Thanks.
> > > > - Chris
> > >
> > > Not any help, just an observation that github does something similar,
> > > when viewing the same directory I get a message:
> > >
> > > Sorry, we had to truncate this directory to 1,000 files. 933 entries
> > > were omitted from the list.
> > >
> > > I guess this is an issue where others host for us, they are limiting
> > > resource intensive ops, such as the Gitlab diff restriction.

-- 
Graham Bloice

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe