Wireshark mailing list archives

Re: Trouble uploading Wireshark enhancement


From: Fulko Hew <fulko.hew () gmail com>
Date: Sat, 24 Oct 2020 00:56:46 -0400

On Sat, Oct 24, 2020 at 12:15 AM chuck c <bubbasnmp () gmail com> wrote:

https://gitlab.com/wireshark/wireshark/-/merge_requests/698

Fulko Hew @fulko.hew closed 2 hours ago
Fulko Hew @fulko.hew reopened 2 hours ago
Fulko Hew @fulko.hew closed 2 hours ago

If it will let you reopen again that would be good.


Done, it's reopened.

As it is now I don't think it will be seen as a pending merge.

On Fri, Oct 23, 2020 at 9:17 PM Fulko Hew <fulko.hew () gmail com> wrote:

Thanks for all the advice. I think I've gotten further.
I got as far as the 'press the “Submit merge request” button' step
and did it.

I then saw a page that described my merge request, and added a comment
with an attached PCAP file to use for testing.

At the bottom was a 'close merge request' button, so I pressed it
assuming that would complete my submission.  I'm having my doubts,
Should I have left it as open?  (or should I re-open it?)



___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org
?subject=unsubscribe

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org
?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

Current thread: