Re: Build without LUA fails

[Pascal Quantin <pascal () wireshark org>]

Le jeu. 19 mars 2020 à 08:54, Anders Broman <anders.broman () ericsson com> a
écrit :

> *From:* Pascal Quantin <pascal () wireshark org>
> *Sent:* den 17 mars 2020 10:13
> *To:* Developer support list for Wireshark <wireshark-dev () wireshark org>
> *Cc:* Anders Broman <anders.broman () ericsson com>
> *Subject:* Re: [Wireshark-dev] Build without LUA fails
>
>
>
> Hi Anders,
>
>
>
> Le mar. 17 mars 2020 à 10:02, Anders Broman via Wireshark-dev <
> wireshark-dev () wireshark org> a écrit :
>
> Hi,
>
> Someone at work is trying to build without LUA and getting, from cmake:
>
>
>
> :
>
> - The following OPTIONAL packages have not been found:
>
>
>
> * LIBSSH (required version >= 0.6), Library for implementing SSH clients, <
> https://www.libssh.org/
> <https://protect2.fireeye.com/v1/url?k=26994e1c-7a136cc8-26990e87-0cc47ad93e6a-bf41698e2320f659&q=1&e=d79c2d7b-43e8-40b7-8bf9-9570ae22d886&u=https%3A%2F%2Fwww.libssh.org%2F>
> >
>
>    extcap remote SSH interfaces (sshdump, ciscodump)
>
> * Systemd, System and Service Manager (libraries), <
> https://freedesktop.org/wiki/Software/systemd/
> <https://protect2.fireeye.com/v1/url?k=fe7da14b-a2f7839f-fe7de1d0-0cc47ad93e6a-59860c2d4f2e2152&q=1&e=d79c2d7b-43e8-40b7-8bf9-9570ae22d886&u=https%3A%2F%2Ffreedesktop.org%2Fwiki%2FSoftware%2Fsystemd%2F>
> >
>
>   Support for systemd journal extcap interface (sdjournal)
>
> * MaxMindDB, C library for the MaxMind DB file format, <
> https://github.com/maxmind/libmaxminddb
> <https://protect2.fireeye.com/v1/url?k=a2f64434-fe7c66e0-a2f604af-0cc47ad93e6a-c422963fef79097e&q=1&e=d79c2d7b-43e8-40b7-8bf9-9570ae22d886&u=https%3A%2F%2Fgithub.com%2Fmaxmind%2Flibmaxminddb>
> >
>
>    Support for GeoIP lookup
>
> * SMI
>
> * Minizip, C library for supporting zip/unzip functionality, <
> https://www.winimage.com/zLibDll/minizip.html
> <https://protect2.fireeye.com/v1/url?k=ecbe0ffc-b0342d28-ecbe4f67-0cc47ad93e6a-458ff04972920839&q=1&e=d79c2d7b-43e8-40b7-8bf9-9570ae22d886&u=https%3A%2F%2Fwww.winimage.com%2FzLibDll%2Fminizip.html>
> >
>
>    Support for profiles import/export
>
> * BROTLI
>
> * LZ4, LZ4 is lossless compression algorithm used in some protocol
> (CQL...), <http://www.lz4.org
> <https://protect2.fireeye.com/v1/url?k=31a16480-6d2b4654-31a1241b-0cc47ad93e6a-60ca5d75f4a68dec&q=1&e=d79c2d7b-43e8-40b7-8bf9-9570ae22d886&u=http%3A%2F%2Fwww.lz4.org%2F>
> >
>
>    LZ4 decompression in CQL and Kafka dissectors
>
> * SNAPPY, A fast compressor/decompressor from Google, <
> https://google.github.io/snappy/
> <https://protect2.fireeye.com/v1/url?k=ffbdd3e3-a337f137-ffbd9378-0cc47ad93e6a-aa1c45afdd0254a1&q=1&e=d79c2d7b-43e8-40b7-8bf9-9570ae22d886&u=https%3A%2F%2Fgoogle.github.io%2Fsnappy%2F>
> >
>
>    Snappy decompression in CQL and Kafka dissectors
>
> * ZSTD (required version >= 1.0.0), A compressor/decompressor from
> Facebook providing better compression than Snappy at a cost of speed, <
> https://facebook.github.io/zstd/
> <https://protect2.fireeye.com/v1/url?k=8e4a792c-d2c05bf8-8e4a39b7-0cc47ad93e6a-3c554c55bddcd6e3&q=1&e=d79c2d7b-43e8-40b7-8bf9-9570ae22d886&u=https%3A%2F%2Ffacebook.github.io%2Fzstd%2F>
> >
>
>    Zstd decompression in Kafka dissector
>
> * LUA (required version >= 5.1)
>
> * SBC, Bluetooth low-complexity, subband codec (SBC) decoder, <
> https://git.kernel.org/pub/scm/bluetooth/sbc.git>
>
>    Support for playing SBC codec in RTP player
>
> * SPANDSP, a library of many DSP functions for telephony, <
> https://www.soft-switch.org
> <https://protect2.fireeye.com/v1/url?k=66abf21d-3a21d0c9-66abb286-0cc47ad93e6a-fc567e190f1951a3&q=1&e=d79c2d7b-43e8-40b7-8bf9-9570ae22d886&u=https%3A%2F%2Fwww.soft-switch.org%2F>
> >
>
>    Support for G.722 and G.726 codecs in RTP player
>
> * BCG729, G.729 decoder, <
> https://www.linphone.org/technical-corner/bcg729/overview
> <https://protect2.fireeye.com/v1/url?k=466d134f-1ae7319b-466d53d4-0cc47ad93e6a-37ddcbaedcd602d7&q=1&e=d79c2d7b-43e8-40b7-8bf9-9570ae22d886&u=https%3A%2F%2Fwww.linphone.org%2Ftechnical-corner%2Fbcg729%2Foverview>
> >
>
>    Support for G.729 codec in RTP player
>
> * ILBC, iLBC decoder, <https://github.com/TimothyGu/libilbc
> <https://protect2.fireeye.com/v1/url?k=4c718298-10fba04c-4c71c203-0cc47ad93e6a-652a8dc4a478f089&q=1&e=d79c2d7b-43e8-40b7-8bf9-9570ae22d886&u=https%3A%2F%2Fgithub.com%2FTimothyGu%2Flibilbc>
> >
>
>    Support for iLBC codec in RTP player
>
> * SpeexDSP, SpeexDSP is a patent-free, Open Source/Free Software DSP
> library, <https://www.speex.org/
> <https://protect2.fireeye.com/v1/url?k=d62dbae1-8aa79835-d62dfa7a-0cc47ad93e6a-70e92ec7f8e18c17&q=1&e=d79c2d7b-43e8-40b7-8bf9-9570ae22d886&u=https%3A%2F%2Fwww.speex.org%2F>
> >
>
>    RTP audio resampling
>
> * Asciidoctor (required version >= 1.5):
>
> CMake Error: The following variables are used in this project, but they
> are set to NOTFOUND.
>
> Please set them or make sure they are set and tested correctly in the
> CMake files:
>
> LUA_INCLUDE_DIR
>
>    used as include directory in directory ..Wireshark /epan
>
> :
>
>
>
> Any ideas?
>
>
>
> Just a blind attmpt. Would th epatch below change something?
>
>
>
> diff --git a/cmake/modules/FindLUA.cmake b/cmake/modules/FindLUA.cmake
> index 2e5e8d476b..ea65b0f89e 100644
> --- a/cmake/modules/FindLUA.cmake
> +++ b/cmake/modules/FindLUA.cmake
> @@ -84,7 +84,7 @@ find_package_handle_standard_args(LUA
>    REQUIRED_VARS LUA_LIBRARY LUA_INCLUDE_DIR LUA_VERSION_NUM
>    VERSION_VAR   LUA_VERSION_NUM)
>
> -IF(LUA_LIBRARY)
> +IF(LUA_FOUND)
>    SET( LUA_LIBRARIES "${LUA_LIBRARY}")
>    SET( LUA_INCLUDE_DIRS ${LUA_INCLUDE_DIR} )
>    if (WIN32)
>
> Best regards,
>
> Pascal.
>
>
>
> That worked, thanks.

Note that the previous patch was incomplete. Lines 103 and 108 must be
changed also. See https://code.wireshark.org/review/#/c/36494/

Best regards,
Pascal.

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe