Wireshark mailing list archives

Re: Windows uninstaller doesn't remove translations.


From: Alexis La Goutte <alexis.lagoutte () gmail com>
Date: Thu, 26 Mar 2020 08:43:52 +0100

Hi Chris,

Can you push the fix on Gerrit ?

Cheers

On Thu, Mar 26, 2020 at 1:27 AM Maynard, Chris via Wireshark-dev <
wireshark-dev () wireshark org> wrote:

I’m building Wireshark on Windows, but I’ve upgraded Qt to 5.12.7.
Everything is fine except when uninstalling Wireshark.  It seems that
Wireshark now installs the translations in C:\Program
Files\Wireshark\styles\translations, but this directory isn’t removed
during the un-installation process.

I *think* this is likely due to Qt 5.12.7 vs. Qt 5.12.6 that the buildbot
is using, but I can’t be completely sure since my environment differs in
other ways too.  Well, for what it’s worth, in case anyone else encounters
this, I modified packaging\nsis\uninstall.nsi as follows, which fixes
this [for me]:

Delete "$INSTDIR\styles\*.*"
*Delete "$INSTDIR\styles\translations\*.*"*

RMDir "$INSTDIR\share"
*RMDir "$INSTDIR\styles\translations"*

- Chris











CONFIDENTIALITY NOTICE: This message is the property of International Game
Technology PLC and/or its subsidiaries and may contain proprietary,
confidential or trade secret information. This message is intended solely
for the use of the addressee. If you are not the intended recipient and
have received this message in error, please delete this message from your
system. Any unauthorized reading, distribution, copying, or other use of
this message or its attachments is strictly prohibited.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org
?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

Current thread: