Wireshark mailing list archives
Re: [Wireshark-commits] master 9b07412: Qt: Add a packet diagram view.
From: "Maynard, Chris via Wireshark-dev" <wireshark-dev () wireshark org>
Date: Tue, 11 Aug 2020 00:59:45 +0000
I think there are a couple of bugs associated with this change. 1) Debug is printed that probably shouldn't be. 2) Panes become empty/missing when changing the layout. Steps to reproduce: I created a pcap file containing a single mal-formed packet based on data from https://stackoverflow.com/questions/63329079/tcp-header-value-initialization (see attached). I then started Wireshark from the command-line and open the file. On Windows, I get the following debug printed to the console: 20:53:55.301 Main Warn Skipping pass 1 tcp.seq_raw 32 32 32 20:53:55.301 Main Warn Skipping pass 1 tcp.ack_raw 64 64 32 Initial Wireshark Layout is the 2nd layout (Pane 1 above Panes 2 and 3) with the Panes set as: Pane 1: Packet List Pane 2: Packet Details Pane 3: Packet Bytes I set "Edit -> Preferences -> Layout" to the 2nd layout (Pane 1 above Panes 2 and 3) with the Panes set as: Pane 1: Packet List Pane 2: Packet Details Pane 3: Packet Diagram More debug as above is printed. I then revert the layout so that Pane 3 is again set to Packet Bytes instead of Packet Diagram. Pane 2 is now blank and Pane 3 appears to be missing altogether. Restarting Wireshark restores both Panes 2 and 3 to their normal expected appearance. - Chris
-----Original Message----- From: Wireshark-commits <wireshark-commits-bounces () wireshark org> On Behalf Of Wireshark code review Sent: Monday, August 10, 2020 2:18 PM To: wireshark-commits () wireshark org Subject: [Wireshark-commits] master 9b07412: Qt: Add a packet diagram view. [THIS MESSAGE ORIGINATED FROM A NON-IGT EMAIL ADDRESS] URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9b 07412277b4436b30410bd07e9cb8ee0b88ddb2 Submitter: "Anders Broman <a.broman58 () gmail com>" Changed: branch: master Repository: wireshark Commits: 9b07412 by Gerald Combs (gerald () wireshark org): Qt: Add a packet diagram view. Add a new top-level view that shows each packet as a series of diagrams similar to what you'd find in a networking textook or an RFC. Add proto_item_set_bits_offset_len so that we can display some diagram fields correctly. Bugs / to do: - Make this a separate dialog instead of a main window view? - Handle bitfields / flags Change-Id: Iba4897a5bf1dcd73929dde6210d5483cf07f54df Reviewed-on: https://code.wireshark.org/review/37497 Reviewed-by: Gerald Combs <gerald () wireshark org> Petri-Dish: Gerald Combs <gerald () wireshark org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58 () gmail com> Actions performed: from e846d23 QUIC: fix compile without LIBGCRYPT_AEAD add 9b07412 Qt: Add a packet diagram view. Summary of changes: docbook/release-notes.adoc | 1 + docbook/wsug_src/WSUG_chapter_use.adoc | 21 + epan/dissectors/packet-ip.c | 18 +- epan/dissectors/packet-tcp.c | 1 + epan/prefs.c | 1 + epan/prefs.h | 3 +- epan/proto.c | 9 + epan/proto.h | 9 +- test/README.test | 1 + test/baseline/dhcp-raw.ek | 8 +- test/baseline/dhcp.jsonraw | 16 +- ui/qt/CMakeLists.txt | 2 + ui/qt/io_graph_dialog.cpp | 2 +- ui/qt/layout_preferences_frame.cpp | 39 ++ ui/qt/layout_preferences_frame.h | 3 + ui/qt/layout_preferences_frame.ui | 30 ++ ui/qt/main_window.cpp | 44 +- ui/qt/main_window.h | 4 +- ui/qt/main_window.ui | 15 + ui/qt/main_window_layout.cpp | 12 +- ui/qt/main_window_slots.cpp | 6 + ui/qt/packet_diagram.cpp | 736 +++++++++++++++++++++++++++++++++ ui/qt/packet_diagram.h | 72 ++++ ui/qt/tcp_stream_dialog.cpp | 1 + ui/qt/utils/field_information.cpp | 19 +- ui/qt/utils/field_information.h | 1 + ui/qt/wireshark_application.cpp | 8 +- ui/qt/wireshark_application.h | 1 + ui/recent.c | 8 + ui/recent.h | 1 + 30 files changed, 1037 insertions(+), 55 deletions(-) create mode 100644 ui/qt/packet_diagram.cpp create mode 100644 ui/qt/packet_diagram.h __________________________________________________________ _________________ Sent via: Wireshark-commits mailing list <wireshark- commits () wireshark org> Archives: https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://www.wireshark.org/mailman/options/wireshark- commits mailto:wireshark-commits- request () wireshark org?subject=unsubscribe
CONFIDENTIALITY NOTICE: This message is the property of International Game Technology PLC and/or its subsidiaries and may contain proprietary, confidential or trade secret information. This message is intended solely for the use of the addressee. If you are not the intended recipient and have received this message in error, please delete this message from your system. Any unauthorized reading, distribution, copying, or other use of this message or its attachments is strictly prohibited.
Attachment:
so_63329079.pcap
Description: so_63329079.pcap
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: [Wireshark-commits] master 9b07412: Qt: Add a packet diagram view. Maynard, Chris via Wireshark-dev (Aug 10)