Wireshark mailing list archives
Re: Question about dissector "enhancement" / bug
From: Anders Broman <a.broman58 () gmail com>
Date: Fri, 28 Jun 2019 06:05:40 +0200
Den fre 28 juni 2019 00:44Jason Cohen <kryojenik2 () gmail com> skrev:
The question about about weather or not adding dissection of additional information in a dissector is an enhancement or a bug; I think this is kind of a grey area. If a dissector doesn't completely dissect a header, would a patch that completes it be considered fixing it? Does it switch between a fix and enhancement if the reason the field is missing is either a wrong offset, or a missing proto_tree_add_item statement? How about handling vendor specific decodes? Particularly where the vendor formerly provided a plugin (under an open source license) and kept it up to date as formats and data changed. When Wireshark.org opted to pull a version of it into libwireshark (which is a good idea) negatively impacts the release of updates. Wireshark is not beholden to a vendors release cycle and a vendor isn't beholden to Wiresharks. But when they do not coincide, functionality that would readily be available is now blocked and delayed. Furthermore, with the inclusion of the now incomplete dissector it makes it unmanageable to provide the full vendor functionality as a plugin. I think there should be some level of flexibility to the inclusion of dissector updates under these circumstances. As a specific example I am referring to: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15876 Jason
It's a slippery slope either way. One can also argue that using the development version is a possibility. At one point Ubuntu was not taking our minor versions but rader did their own with security fixes only. So there's different views on the subject. I'm not opposed to make an exception in this case however as the change is small. What does other people think? Regards Anders ___________________________________________________________________________
Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org ?subject=unsubscribe
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Question about dissector "enhancement" / bug Jason Cohen (Jun 27)
- Re: Question about dissector "enhancement" / bug Anders Broman (Jun 27)
- Re: Question about dissector "enhancement" / bug Pascal Quantin (Jun 27)
- Re: Question about dissector "enhancement" / bug Graham Bloice (Jun 28)
- Re: Question about dissector "enhancement" / bug Jason Cohen (Jun 28)
- Re: Question about dissector "enhancement" / bug Graham Bloice (Jun 28)
- Re: Question about dissector "enhancement" / bug Jason Cohen (Jun 28)
- Re: Question about dissector "enhancement" / bug Maynard, Chris (Jun 28)
- Re: Question about dissector "enhancement" / bug Graham Bloice (Jun 28)
- Re: Question about dissector "enhancement" / bug Guy Harris (Jun 29)
- Re: Question about dissector "enhancement" / bug Jaap Keuter (Jun 28)
- Re: Question about dissector "enhancement" / bug Pascal Quantin (Jun 27)
- Re: Question about dissector "enhancement" / bug Anders Broman (Jun 27)