Re: How to add ilbc library to wireshark CMake?

[Dario Lombardo <lomato () gmail com>]

Hi
For Ubuntu there is tools/debian-setup.sh that installs optional packages
(as this).
I suggest you to test your change at least on this platform since it's the
most common.
Did you make your change compilable without that library? You need some
preprocessor ifdefs for that.
If you push your change as WIP you can add me as reviewer: I have a bunch
of builders for many platforms. I can help you at least to compile it on as
many as possible.


On Sat, Dec 28, 2019, 21:52 Jiří Novák <j.novak () netsystem cz> wrote:

> Hello,
>
>   I finished iLBC codec support and it works fine for decoding and audio
> saving. The only issue is that I'm able to build and test it on Linux only.
>   It depends on iLBC lib from https://github.com/TimothyGu/libilbc. It
> is package ilbc/ilbc-devel on Fedora
> (ilbc-1.1.1-16.fc30.x86_64/ilbc-devel-1.1.1-16.fc30.x86_64)
>
>   I modified/created CMakeLists.txt, CMakeOptions.txt,
> cmake/modules/FindILBC.cmake and tools/rpm-setup.sh.
>   I didn't touched files for Windows/MAC.
>
>   Can I ask anyone to help me to update/test scripts for other platforms
> and petri-dish?
>
>                                                 Best regards,
>
>                                                         Jirka Novak
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> Archives:    https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-request () wireshark org
> ?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe