Wireshark mailing list archives

Re: [Wireshark-commits] master 8d65ccf: Show answers a line at a time, after the request frame and time delta.


From: "Maynard, Chris via Wireshark-dev" <wireshark-dev () wireshark org>
Date: Wed, 25 Dec 2019 17:21:08 +0000

-----Original Message-----
From: Wireshark-commits [mailto:wireshark-commits-bounces () wireshark org]
On Behalf Of Wireshark code review
Sent: Sunday, December 22, 2019 1:01 AM
To: wireshark-commits () wireshark org
Subject: [Wireshark-commits] master 8d65ccf: Show answers a line at a time,
after the request frame and time delta.

URL:
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8d65cc
fee4cb1da05a7e4bae1150ca7f56ce4fb4
Submitter: "Guy Harris <guy () alum mit edu>"
Changed: branch: master
Repository: wireshark

Commits:

8d65ccf by Guy Harris (guy () alum mit edu):

    Show answers a line at a time, after the request frame and time delta.

    Long responses are *really* hard to read if you make them one single
    string item.  Show it a line at a time, as we do with many other
    text-oriented protocols.

    Change-Id: Ie2e81dabeba728ed34772d7015c52b0b047904e8
    Reviewed-on: https://code.wireshark.org/review/35544
    Petri-Dish: Guy Harris <guy () alum mit edu>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy () alum mit edu>


Actions performed:

    from  0442f7a   UI: Fix compilation with Qt 5.14
     add  8d65ccf   Show answers a line at a time, after the request frame and
time delta.


Summary of changes:
 epan/dissectors/packet-whois.c | 23 ++++++++++++++++++++++-
 1 file changed, 22 insertions(+), 1 deletion(-)

With this change, it's no longer possible to right-click on the answer, choose "Copy -> Value" and easily obtain the 
*entire* answer.  Now, you would have to copy each line one at a time to retrieve it.
- Chris

CONFIDENTIALITY NOTICE: This message is the property of International Game Technology PLC and/or its subsidiaries and 
may contain proprietary, confidential or trade secret information. This message is intended solely for the use of the 
addressee. If you are not the intended recipient and have received this message in error, please delete this message 
from your system. Any unauthorized reading, distribution, copying, or other use of this message or its attachments is 
strictly prohibited.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

Current thread: