Wireshark mailing list archives

Re: Gerrit - code review window


From: João Valverde <joao.valverde () tecnico ulisboa pt>
Date: Sun, 2 Sep 2018 19:42:11 +0100



On 02/09/18 19:37, João Valverde wrote:


On 11/08/18 11:48, Jaap Keuter wrote:
Hi,

A change I noticed is the way side-by-side code is presented in the code review window. This used to be two evenly spaced columns on the screen with horizontal scroll bars when the lines were longer than the available width. Both scrollbars were synchronised to help sideways navigation. The new code review window has a width that also defines the word-wrap width, and no horizontal scroll bars anymore. I  particularly don’t like word wrapped code, so this change is unhelpful to me. Worse, there seems to be no option to manage word-wrap.

Word wrap is called "fit to screen" in the preferences but yeah, I miss the horizontal scroll-bar.

The way the changeset windows layout changes with resizing is pretty jarring too and leaves huge amounts of empty space sometimes.

Thoughts?
Jaap

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
            mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

Current thread: