Re: [External] Re: Problem building a dissector for 2.6

["Maynard, Chris" <Christopher.Maynard () IGT com>]

You could also try explicitly building the documentation, i.e., with all_guides.vcxproj to see if the documentation 
builds properly before attempting to build the NSIS prep and installer?  The Windows Server 2016 x86 buildbot does 
this, although the Windows Server 2016 x64 buildbot does not for whatever reason.  The buildbots are here by the way: 
https://buildbot.wireshark.org/wireshark-master/waterfall.

If you didn’t install asciidoctorj, then it might be worth re-reading Section 2.2, “Win32/64: Step-by-step Guide”, from 
the Wireshark Developer’s Guide (https://www.wireshark.org/docs/wsdg_html_chunked/ChSetupWin32.html); asciidoctorj is 
mentioned in section 2.2.8.

Regarding custom_plugins.txt, you’re almost right.  The example should read:

;File "${STAGING_DIR}\plugins\${VERSION_MAJOR}.${VERSION_MINOR}\epan\foo.dll"

- Chris


From: Wireshark-dev [mailto:wireshark-dev-bounces () wireshark org] On Behalf Of Andy Ling
Sent: Monday, May 21, 2018 2:28 PM
To: Developer support list for Wireshark <wireshark-dev () wireshark org>
Subject: Re: [Wireshark-dev] [External] Re: Problem building a dissector for 2.6

Yes, I've built the preparation project and it didn't generate any errors.

I haven't installed Asciidocotorj, but nothing moaned about missing tools and I didn't notice mention of it in the 
build instructions (I probably didn't look hard enough). I will investigate tomorrow.

Thanks

Andy Ling
________________________________
From: Wireshark-dev [wireshark-dev-bounces () wireshark org] on behalf of Graham Bloice [graham.bloice () trihedral com]
Sent: 21 May 2018 18:26
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] [External] Re: Problem building a dissector for 2.6
This Message originated outside your organization.
________________________________

On Mon, 21 May 2018 at 17:28, Andy Ling <Andy.Ling () s-a-m com<mailto:Andy.Ling () s-a-m com>> wrote:
Hi,

My next problem is building an installer. Running the build generates the error…

         SectionGroupEnd
         Section: "User's Guide" ->(SecUsersGuide)
         SetOutPath: "$INSTDIR"
         File: "D:\wireshark-2.6.0\build_win64\docbook\user-guide.chm" -> no files found.

So it looks like the user guide didn’t get built. What do I need to do to fix this.

Have you built the installer "preparation" project, e.g. nsis_package_prep.vcxproj?  This builds the docs.

If you have, do you have all the prerequisites for building the docs, Asciidoctorj etc.?


Also I’m guessing the custom_plugins.txt format has changed. Is something like this correct?
File "${STAGING_DIR}\plugins\${VERSION_MAJOR}.${VERSION_MINOR}\foo\foo.dll"

Thanks for any help

Andy Ling


From: Wireshark-dev [mailto:wireshark-dev-bounces () wireshark org<mailto:wireshark-dev-bounces () wireshark org>] On 
Behalf Of Andy Ling
Sent: Mon 21 May 2018 16:57
To: 'Developer support list for Wireshark'
Subject: Re: [Wireshark-dev] [External] Re: Problem building a dissector for 2.6

This Message originated outside your organization.
________________________________
Thanks, that seems to have fixed it.

I’ve also fixed the link error by adding a #include <stdio.h> to the dissector. So I’ve got everything built.

One other question.

I have some other dissectors that used to live in their own directories in plugins. The changes to CMakeLists.txt seem 
to enforce these to be in a sub directory of plugins. Is that right?

Regards

Andy Ling


From: Wireshark-dev [mailto:wireshark-dev-bounces () wireshark org<mailto:wireshark-dev-bounces () wireshark org>] On 
Behalf Of Graham Bloice
Sent: Mon 21 May 2018 16:37
To: Developer support list for Wireshark
Subject: [External] Re: [Wireshark-dev] Problem building a dissector for 2.6

This Message originated outside your organization.
________________________________

On Mon, 21 May 2018 at 16:02, Andy Ling <Andy.Ling () s-a-m com<mailto:Andy.Ling () s-a-m com>> wrote:
Hi,

I am trying to update to Wireshark 2.6 building for Windows 64bit. I have a custom GIOP dissector which was previously 
built for Wireshark 2.2.5
The dissector is in the file packet-q_quentin.c and I have copied that file to the epan/dissectors directory.

First, adding it to the CMakeListsCustom.txt file in epan/dissectors causes a build error – packet-q_quentin.c does not 
exist, except it does.

I have run cmake with a clean build directory and it still fails. So there seems to be a problem with the custom cmake 
list stuff.

Try prefixing your dissector with the cmake source path, e.g.

    ${CMAKE_CURRENT_SOURCE_DIR}/packet-q_quentin.c

Recent changes to the build infrastructure haven't updated the files not normally used in our builds, i.e. 
CMakeListsCustom.txt.example


To try and move on, I added my dissector to the CMakeLists.txt file. This now builds the dissector, but I get a link 
error saying unresolved symbol sprintf (which is used in my dissector).

I’m using Visual Studio 2015

So what do I need to do to make the custom cmake list work and how do I fix the link error.

Thanks for any help

Regards

Andy Ling



--
Graham Bloice

--
Graham Bloice

________________________________
This email has been scanned for email related threats and delivered safely by Mimecast.
For more information please visit http://www.mimecast.com
________________________________
CONFIDENTIALITY NOTICE: This message is the property of International Game Technology PLC and/or its subsidiaries and 
may contain proprietary, confidential or trade secret information.  This message is intended solely for the use of the 
addressee.  If you are not the intended recipient and have received this message in error, please delete this message 
from your system. Any unauthorized reading, distribution, copying, or other use of this message or its attachments is 
strictly prohibited.

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe