Wireshark mailing list archives
Re: adding a new nvme dissector - pre-commit verifications
From: Michael Mann <mmann78 () netscape net>
Date: Wed, 25 Jan 2017 15:34:46 -0500
Note that a dissector for the NVME protocol was recently submitted (https://code.wireshark.org/review/19063). I presume you've rebased to the latest commits on master to include that functionality (and maybe you're just adding support for more commands?) -----Original Message----- From: Nitzan Carmi <nitzanc () mellanox com> To: wireshark-dev <wireshark-dev () wireshark org> Sent: Wed, Jan 25, 2017 2:13 pm Subject: [Wireshark-dev] adding a new nvme dissector - pre-commit verifications Hi, At the past month I've been working on a new dissector for Wireshark, to parse NVME protocol (with a focus on the fabrics channel – Infiniband/RDMA). So far, although not all commands are fully parsed yet (lots of commands to cover), the dissection flow is working correctly, thus I think I reached a milestone and this is a good time to share the code and take comments before I continue. But, since I am new to Wireshark, I would like to know (and save everybody's time) if there are things I need to check or pay attention to (beyond the fuzz testing I already read about) Before I push my dissector to gerrit for review. Thanks! Nitzan. ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- adding a new nvme dissector - pre-commit verifications Nitzan Carmi (Jan 25)
- Re: adding a new nvme dissector - pre-commit verifications Alexis La Goutte (Jan 25)
- Re: adding a new nvme dissector - pre-commit verifications Pascal Quantin (Jan 25)
- Re: adding a new nvme dissector - pre-commit verifications Michael Mann (Jan 25)