Re: main_toolbar.c in code tree but not in solution

[Pascal Quantin <pascal.quantin () gmail com>]

Le 17 janv. 2017 19:27, "Paul Offord" <Paul.Offord () advance7 com> a écrit :

I generate it with:



cmake -DENABLE_CHM_GUIDES=on -G "Visual Studio 12 Win64" ..\wireshark



Is there anything else?


Looks like you are using master branch (which is fine to push the fix) that
has GTK UI disabled by default. Add -DBUILD_wireshark_gtk=on to your
command line.



I just tried erasing the whole of the wsbuild64 directory and running the
above command.  I still get a solution without the gtkui folder.



The solution builds fine and I can run Wireshark (Qt) without a problem.



Best regards…Paul



*From:* wireshark-dev-bounces () wireshark org [mailto:wireshark-dev-bounces@
wireshark.org] *On Behalf Of *Graham Bloice
*Sent:* 17 January 2017 18:00

*To:* Developer support list for Wireshark <wireshark-dev () wireshark org>
*Subject:* Re: [Wireshark-dev] main_toolbar.c in code tree but not in
solution







On 17 January 2017 at 17:50, Paul Offord <Paul.Offord () advance7 com> wrote:

Hi Graham,



I don’t seem to have that folder in my solution.  Here’s a screenshot:





I’ve changed main_toolbar.c by just navigating to the filesystem directory
and then opening it.  I’m in git/git-review/Windows hell at the moment –
I’ll take that up on a separate mail thread.  Once I get that working I’ll
push the fix.



It's definitely built, look at the build output on the buildbot:
https://buildbot.wireshark.org/wireshark-2.2/builders/
Windows%20Server%202012%20R2%20x64/builds/420/steps/compile_1/logs/stdio
and look for main_toolbar.c



I suspect you've somehow generated a solution without gtk being enabled.





Best regards…Paul



*From:* wireshark-dev-bounces () wireshark org [mailto:wireshark-dev-bounces@
wireshark.org] *On Behalf Of *Graham Bloice
*Sent:* 17 January 2017 17:31
*To:* Developer support list for Wireshark <wireshark-dev () wireshark org>
*Subject:* Re: [Wireshark-dev] main_toolbar.c in code tree but not in
solution







On 17 January 2017 at 17:04, Paul Offord <Paul.Offord () advance7 com> wrote:

Hi,



I’m working on a fix for Bug 12973.  It’s a very simple fix to
main_window.cpp for the Qt UI and main_toolbar.c for the GTK one.  I’m
working with source from a git clone taken this morning.  Although
main_window.cpp is showing in the VS 2013 solution, main_toobar.c doesn’t.
Both files are in the code tree.



   - Is main_toolbar.c no longer needed?
   - Do I need to code a fix for the GTK UI?



Thanks and regards…Paul




main_toolbar.c is still used (see UI\gtkui\Source Files in the solution
explorer) and yes, preferably fix both.



-- 

Graham Bloice





-- 

Graham Bloice

______________________________________________________________________

This message contains confidential information and is intended only for the
individual named. If you are not the named addressee you should not
disseminate, distribute or copy this e-mail. Please notify the sender
immediately by e-mail if you have received this e-mail by mistake and
delete this e-mail from your system.

Any views or opinions expressed are solely those of the author and do not
necessarily represent those of Advance Seven Ltd. E-mail transmission
cannot be guaranteed to be secure or error-free as information could be
intercepted, corrupted, lost, destroyed, arrive late or incomplete, or
contain viruses. The sender therefore does not accept liability for any
errors or omissions in the contents of this message, which arise as a
result of e-mail transmission.

Advance Seven Ltd. Registered in England & Wales numbered 2373877 at
Endeavour House, Coopers End Lane, Stansted, Essex CM24 1SJ

______________________________________________________________________
This email has been scanned by the Symantec Email Security.cloud service.
For more information please visit http://www.symanteccloud.com
______________________________________________________________________

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe