Wireshark mailing list archives

Re: Crash in epan/geoip_db.c


From: Evan Huus <eapache () gmail com>
Date: Wed, 22 Feb 2017 14:55:04 +0000

On Wed, Feb 22, 2017 at 09:50 Dario Lombardo <dario.lombardo.ml () gmail com>
wrote:

On Tue, Feb 21, 2017 at 11:38 PM, João Valverde <
joao.valverde () tecnico ulisboa pt> wrote:


Fixes 850393b57bdd7011780f4cf897d4a2467f58a673. Please push to Gerrit.
Bonus points for fixing the cast too.


I pushed a patch that replaces g_free with free. Now the problem is that
checkAPI doesn't allow free! No way to make petri-dish pass. We can:


checkAPI doesn't allow free because it also doesn't allow malloc; if the
malloced memory is coming from library internals somewhere, does the
library itself have a cleanup method we could call instead?


- merge without PD
- patch checkAPI to allow some forbidden calls in some files

Is it worth the latter or we should be fine with the former?
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org
?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

Current thread: