Re: Patch to fix LANforge protcol.

[Alexis La Goutte <alexis.lagoutte () gmail com>]

Hi Brent,

I have push a better fix (fix wrong offset) in
https://code.wireshark.org/review/#/c/15800/

It is better to send issue on bugtracker (and push fix directly on Gerrit)

Cheers

On Fri, Jun 10, 2016 at 12:04 AM, Brent Lovelace <
brent.lovelace () candelatech com> wrote:

> On 16-06-09 02:33 PM, Pascal Quantin wrote:
>
> Hi Brent,
>
> Le 9 juin 2016 23:20, "Brent Lovelace" < <brent.lovelace () candelatech com>
> brent.lovelace () candelatech com> a écrit :
> > The attached patch fixes a bug we noticed in wireshark.
>
> The change was made because tvb_memeql is known to be slow.
> What is the issue exactly? Related to endianness preventing to identify
> the magic?
> Could you a share a pcap file demonstrating the issue?
>
> Best regards,
> Pascal.
>
>
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org> <wireshark-dev () wireshark org>
> Archives:    https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-request () wireshark org?subject=unsubscribe <wireshark-dev-request () wireshark 
> org?subject=unsubscribe>
>
> Hey Pascal,
>
> I've attached a pcap file with LANforge UDP packets. The protocol in these
> packets should be LANforge but they decode as UDP. The patch is intended to
> fix the protocol decoding issue.
>
> Thanks,
> Brent
>
> --
> Brent Lovelace
> Candela Technologiesbrent.lovelace () candelatech com
> Office: 360-380-1618
>
>
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> Archives:    https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-request () wireshark org
> ?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe