Wireshark mailing list archives
Re: proto.h extension (unit strings)
From: Michal Labedzki <michal.labedzki () tieto com>
Date: Mon, 12 Dec 2016 08:18:03 +0100
Good idea. I have similar problem with Bluetooth protocols. There is a lot of something like that: "Latency = N * 0.625 ms (1 Baseband slot)" So I want to display [ms] instead of [slot] (or maybe both? [new use case]). What should I do in that case (N * 0.625)? 1. use own BASE_CUSTOM (dissector files) 2. public-predefined base custom function 3. combine it with "BASE_UNIT" (unit_name_string_get_value in base custom function) or BASE_UNIT | BASE_CUSTOM? There is a need to update README.dissector (etc.) I think there should be abbrev-form of unit in "struct unit_name_string" (second, seconds, s) and provide user option to choose between full-form and abbrev. I am not sure, but I will probably use abbreviation. I am not sure if mixing abbrev/non-abbrev on dissector level is good idea. On 12 December 2016 at 04:17, Michael Mann <mmann78 () netscape net> wrote:
I thought this was a good idea, just took a while to get around to it: https://code.wireshark.org/review/19211 -----Original Message----- From: Guy Harris <guy () alum mit edu> To: Developer support list for Wireshark <wireshark-dev () wireshark org> Sent: Fri, May 8, 2015 3:09 pm Subject: Re: [Wireshark-dev] proto.h extension On May 8, 2015, at 7:06 AM, "John Dill" <John.Dill () greenfieldeng com> wrote:Message: 3 Date: Thu, 7 May 2015 11:29:22 -0700 From: Guy Harris <guy () alum mit edu> To: Developer support list for Wireshark <wireshark-dev () wireshark org> Subject: Re: [Wireshark-dev] proto.h extension Message-ID: <CF2E7490-F023-49C2-8383-6C1A1394B4E7 () alum mit edu> Content-Type: text/plain; charset=iso-8859-1 On May 7, 2015, at 8:13 AM, "John Dill" <John.Dill () greenfieldeng com>wrote:I have a couple of extensions that I created for the Wireshark baselinethat we're using (1.10.x). The diffs to proto.h and proto.c show thecodechanges to add a couple of features that I've found useful, unit strings and hiding the bits for bitmask header fields.http://codepad.org/KTGdEL1tYou need more than /* Following constants have to be ORed with a base_display_e whendissector* want to control aspects of the display string for a header_field_info*/as a comment there - you need comments explaining what each of thoseflags actually *does*.Guy, Sorry it wasn't clear. Starting from this snippet... /* * BASE_UNIT_STRING - Append a unit string to the numeric valueThat one's reasonable; I've thought of a similar option.* * When active, Wireshark will append a unit string declared as a * simple 'char *' for the 'strings' to the numeric value.You might want to, instead, have it be a structure with a pair of strings, so that if the field has the value 1, you can print the singular rather than the plural, e.g.: struct unit_names { char *singular; /* name to use for 1 unit */ char *plural; /* name to use for < 1 or > 1 units */ }; struct unit_names feet { "foot", "feet" }; { &hf_MFD_State_Data_Slew_Elevation_Ch1, { "Slew_Elevation_Ch1", "ndo.MFD_State_Data.Slew_Elevation_Ch1", FT_FLOAT, BASE_NONE | BASE_UNIT_STRING, &feet, 0x0, NULL, HFILL } }, (For floating-point numbers, "1 unit" means "*exactly* 1 unit", i.e. an exact floating-point comparison with 1x2^0.) We could either 1) require that both be non-null or 2) assume that, if the plural is null, you can pluralize using the standard rules of English. Does anybody have a preference there? ____________________________________________________________ _______________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject= unsubscribe
-- Pozdrawiam / Best regards ------------------------------------------------------------------------------------------------------------- Michał Łabędzki, Software Engineer Tieto Corporation Product Development Services http://www.tieto.com / http://www.tieto.pl --- ASCII: Michal Labedzki location: Swobodna 1 Street, 50-088 Wrocław, Poland room: 5.01 (desk next to 5.08) --- Please note: The information contained in this message may be legally privileged and confidential and protected from disclosure. If the reader of this message is not the intended recipient, you are hereby notified that any unauthorised use, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify us immediately by replying to the message and deleting it from your computer. Thank You. --- Please consider the environment before printing this e-mail. --- Tieto Poland spółka z ograniczoną odpowiedzialnością z siedzibą w Szczecinie, ul. Malczewskiego 26. Zarejestrowana w Sądzie Rejonowym Szczecin-Centrum w Szczecinie, XIII Wydział Gospodarczy Krajowego Rejestru Sądowego pod numerem 0000124858. NIP: 8542085557. REGON: 812023656. Kapitał zakładowy: 4 271500 PLN
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: proto.h extension (unit strings) Michael Mann (Dec 11)
- Re: proto.h extension (unit strings) Michal Labedzki (Dec 11)
- Re: proto.h extension (unit strings) Guy Harris (Dec 12)
- <Possible follow-ups>
- Re: proto.h extension (unit strings) Michael Mann (Dec 12)
- Re: proto.h extension (unit strings) John Dill (Dec 12)
- Re: proto.h extension (unit strings) Michael Mann (Dec 16)
- Re: proto.h extension (unit strings) Pascal Quantin (Dec 16)
- Re: proto.h extension (unit strings) Michael Mann (Dec 16)
- Re: proto.h extension (unit strings) Pascal Quantin (Dec 16)
- Re: proto.h extension (unit strings) Pascal Quantin (Dec 16)
- Re: proto.h extension (unit strings) Stig Bjørlykke (Dec 16)
- Re: proto.h extension (unit strings) Michal Labedzki (Dec 11)