Re: [Wireshark-commits] master f50ff01: Squelch 64-bit-to-32-bit warnings by just casting to int.

[Evan Huus <eapache () gmail com>]

On Sun, Sep 13, 2015 at 4:28 PM, Wireshark code review
<code-review-do-not-reply () wireshark org> wrote:
> URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f50ff0149e32158b11413715acaeef77478d3fd9
> Submitter: Guy Harris (guy () alum mit edu)
> Changed: branch: master
> Repository: wireshark
>
> Commits:
>
> f50ff01 by Guy Harris (guy () alum mit edu):
>
>     Squelch 64-bit-to-32-bit warnings by just casting to int.
>
>     Those lengths had better fit in an int if they're added to packet offsets.
>
>     (BTW, gsize is the spawn of Satan; it should never be used except when
>     you're dealing with GLib.  It *should* have just been another name for
>     size_t, but it's 32 bits on 64-bit Windows, which means it's narrower
>     than size_t, which causes us some pain with g_snprintf().)

Today I learned.

>     Change-Id: Icd8f0632242303dbea0d80e0dad45b317097daaa
>     Reviewed-on: https://code.wireshark.org/review/10516
>     Reviewed-by: Guy Harris <guy () alum mit edu>
>
>
> Actions performed:
>
>     from  eed56ee   bootp: simplify avaya parameter parsing
>     adds  f50ff01   Squelch 64-bit-to-32-bit warnings by just casting to int.
>
>
> Summary of changes:
>  epan/dissectors/packet-bootp.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> ___________________________________________________________________________
> Sent via:    Wireshark-commits mailing list <wireshark-commits () wireshark org>
> Archives:    https://www.wireshark.org/lists/wireshark-commits
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
>              mailto:wireshark-commits-request () wireshark org?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe