Re: Qt: Convert ProtoTree from QTreeWidget to Model/View

[Gerald Combs <gerald () wireshark org>]

On 3/9/15 7:56 AM, Peter Wu wrote:
> Hi,
>
> I have recently discovered that the Qt UI gets in an inconsistent state
> (leading to crashes) whenever a packet dialog is open and packets are
> re-dissected. This is reported at
> https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11044
>
> Before proceeding to a reimplementation attempt using Model/View, I
> would like to solicit for some feedback. Was the QTreeWidget choice done
> consciously? Do you foresee issues with sharing field items via the same
> model? Is someone already working on this?

A QTreeWidget was chosen lazily, i.e. it did the job at the time. A custom
model might make more sense given that we have a large limit on the number
of tree items (MAX_TREE_ITEMS = 1e6).

Having independent models lets each packet dialog persist across files.
Would a shared model still allow that?
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe