Wireshark mailing list archives
Re: Autogenerated files in source tree [Was: asn2wrs problem]
From: Evan Huus <eapache () gmail com>
Date: Thu, 25 Jun 2015 14:38:10 -0700
On Thu, Jun 25, 2015 at 2:36 PM, Joerg Mayer <jmayer () loplof de> wrote:
On Thu, Jun 25, 2015 at 02:24:05PM -0700, Pascal Quantin wrote:Yeah that's my fault: I did some API change yesterday and did not realize that CREDSSP was an autogenerated dissector. I will fix this in a few minutes.OK, which brings me back to the topic that we should have as few autogenerated dissectors in our source tree as possible. I don't think the additional compile time qualifies as a counter argument, and phython is required to build Wireshark as well. So why keep doing that? If it's OK, I'd like to do a PoC patch for asn1.
I'd be happy to see that, I tried once but my build-system skills were not up to it.
For those instances where we want to keep the generated dissectors in the source tree: Is there a way to prevent accidental changes (i.e. opening the file not at the top but at a given line or automated search/replace scripts? Does setting these files to read only look like a possible solution?Sorry about that,No problem - I was just testing the new old cmake asn1 generation and it gave me the opportunity to once again start this discussion ;-) -- Joerg Mayer <jmayer () loplof de> We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology. ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- asn2wrs problem Joerg Mayer (Jun 25)
- Re: asn2wrs problem Pascal Quantin (Jun 25)
- Re: asn2wrs problem Pascal Quantin (Jun 25)
- Autogenerated files in source tree [Was: asn2wrs problem] Joerg Mayer (Jun 25)
- Re: Autogenerated files in source tree [Was: asn2wrs problem] Evan Huus (Jun 25)
- Re: Autogenerated files in source tree [Was: asn2wrs problem] mmann78 (Jun 25)
- Re: asn2wrs problem Pascal Quantin (Jun 25)