Re: [Wireshark-commits] master 1e1d96f: Modify the errorcode defenition to suit ANSI MAP, this is (probably) OK as ANSI MAP is currently the only user of ANSI TCAP. Bug: 6112

[Hadriel Kaplan <hadrielk () yahoo com>]

We could put a check for that in a post-commit hook, either in commit-msg or post-commit hook - if the check is in 
commit-msg we could even auto-fix it for the developer, but the hook would have to include the change-id creation. 
(i.e., added to the existing commit-msg hook)

-hadriel


On Jan 15, 2015, at 10:21 AM, Evan Huus <eapache () gmail com> wrote:

> Public service announcement, since I've gotten a few emails from
> people confused why bugzilla integration seems flaky:
>
> The bugzilla integration will not automatically pick up on the Bug:
> #### line unless it is part of the footer (i.e. not separated by blank
> lines from the rest of the Change-Id: lines and similar). The
> following message will work:
>
> > Make some change
> >
> > Bug: 1234
> > Change-Id: Iblahblahblah
>
> But this one won't:
>
> > Make some change
> > Bug: 1234
> >
> > Change-Id: Iblahblahblah
>
> It seems a silly limitation, but that's how Gerrit works, *shrug*.
>
> On Thu, Jan 15, 2015 at 10:05 AM, Wireshark code review
> <code-review-do-not-reply () wireshark org> wrote:
> > URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1e1d96f108bde4284c1b2117a1fe9d46b4a82edc
> > Submitter: Anders Broman (a.broman58 () gmail com)
> > Changed: branch: master
> > Repository: wireshark
> >
> > Commits:
> >
> > 1e1d96f by AndersBroman (anders.broman () ericsson com):
> >
> >    Modify the errorcode defenition to suit ANSI MAP, this is (probably) OK as
> >    ANSI MAP is currently the only user of ANSI TCAP.
> >    Bug: 6112
> >
> >    Change-Id: I49f89c862ddc8351091a9a939415e4ba6e7603f5
> >    Reviewed-on: https://code.wireshark.org/review/6546
> >    Reviewed-by: Anders Broman <a.broman58 () gmail com>
> >
> >
> > Actions performed:
> >
> >    from  ef0435b   ZigBee: don't use packet_scope outside of dissection
> >    adds  1e1d96f   Modify the errorcode defenition to suit ANSI MAP, this is (probably) OK as ANSI MAP is currently 
> > the only user of ANSI TCAP. Bug: 6112
> >
> >
> > Summary of changes:
> > .../TCAP-Remote-Operations-Information-Objects.asn |   20 +++++++++--
> > epan/dissectors/packet-ansi_tcap.c                 |   36 +++++++++++++++++---
> > 2 files changed, 49 insertions(+), 7 deletions(-)
> > ___________________________________________________________________________
> > Sent via:    Wireshark-commits mailing list <wireshark-commits () wireshark org>
> > Archives:    http://www.wireshark.org/lists/wireshark-commits
> > Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
> >             mailto:wireshark-commits-request () wireshark org?subject=unsubscribe
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> Archives:    http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe