Re: Npcap 0.04 call for test

[Pascal Quantin <pascal.quantin () gmail com>]

2015-08-24 13:18 GMT+02:00 Yang Luo <hsluoyb () gmail com>:

> Hi Pascal,
>
> I think you would like to add the link types that WinPcap defined but NDIS
> doesn't define, see:
> https://github.com/wireshark/winpcap/blob/master/Common/Packet32.h from
> Line: 76. Comments said that these are "Custom linktype: NDIS doesn't
> provide an equivalent". And it seems that Npcap loopback adapter will
> continue to use the "NdisMediumNull - DLT_NULL" pair for now.

Thanks for the link Yang, I was not aware of those defines. I also added
them to the patch.

Pascal.


> On Mon, Aug 24, 2015 at 7:00 PM, Pascal Quantin <pascal.quantin () gmail com>
> wrote:
>
> > 2015-08-24 12:30 GMT+02:00 Yang Luo <hsluoyb () gmail com>:
> >
> > > Hi Pascal,
> > >
> > > On Mon, Aug 24, 2015 at 5:46 PM, Pascal Quantin <
> > > pascal.quantin () gmail com> wrote:
> > >
> > > > > I personally think data returned by OID_GEN_MEDIA_IN_USE should be
> > > > > identical with the one returned by OID_GEN_MEDIA_SUPPORTED for our loopback
> > > > > condition based on MSDN explanation, and it's "media" instead of "medium",
> > > > > so I think the display string should be modified to "Media in use" instead
> > > > > of "Medium in use".
> > > >
> > > > Media is the plural form of medium. "media supported" could list
> > > > several medium, while only one can be in use at a given time. So the
> > > > current wording seems OK to me.
> > > > Note that I updated the list of enum (so as to support loopback value)
> > > > in https://code.wireshark.org/review/#/c/10225/
> > > I knew that media is the plural form of medium:). And I rechecked the
> > > MSDN about OID_GEN_MEDIA_IN_USE  (see:
> > > https://msdn.microsoft.com/en-us/library/windows/hardware/ff569607(v=vs.85).aspx),
> > > it said "*As a query, the OID_GEN_MEDIA_IN_USE OID specifies a complete
> > > list of the media types that the NIC currently uses.*". So I think that
> > > in Microsoft' point of view, "multiple" media can be in use at a given time
> > > (this looks weird for me too). But in practice, I didn't see "multiple"
> > > media are ever returned on the OID_GEN_MEDIA_IN_USE or
> > > OID_GEN_MEDIA_SUPPORTED request.
> >
> > I amended https://code.wireshark.org/review/#/c/10225/ with the rename.
> >
> >
> > > Cheers,
> > > Yang
> > >
> > >
> > >
> > > ___________________________________________________________________________
> > > Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> > > Archives:    https://www.wireshark.org/lists/wireshark-dev
> > > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
> > >              mailto:wireshark-dev-request () wireshark org
> > > ?subject=unsubscribe
> >
> >
> >
> > ___________________________________________________________________________
> > Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> > Archives:    https://www.wireshark.org/lists/wireshark-dev
> > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
> >              mailto:wireshark-dev-request () wireshark org
> > ?subject=unsubscribe
>
>
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> Archives:    https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-request () wireshark org
> ?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe